Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: Source/core/dom/NodeRenderingContext.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/NodeRenderingContext.h ('k') | Source/core/dom/PseudoElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 60
61 NodeRenderingContext::NodeRenderingContext(Node* node, RenderStyle* style) 61 NodeRenderingContext::NodeRenderingContext(Node* node, RenderStyle* style)
62 : m_node(node) 62 : m_node(node)
63 , m_renderingParent(0) 63 , m_renderingParent(0)
64 , m_style(style) 64 , m_style(style)
65 , m_parentFlowRenderer(0) 65 , m_parentFlowRenderer(0)
66 { 66 {
67 } 67 }
68 68
69 NodeRenderingContext::NodeRenderingContext(Node* node, const Node::AttachContext & context)
70 : m_node(node)
71 , m_style(context.resolvedStyle)
72 , m_parentFlowRenderer(0)
73 {
74 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetails);
75 }
76
69 NodeRenderingContext::~NodeRenderingContext() 77 NodeRenderingContext::~NodeRenderingContext()
70 { 78 {
71 } 79 }
72 80
73 static bool isRendererReparented(const RenderObject* renderer) 81 static bool isRendererReparented(const RenderObject* renderer)
74 { 82 {
75 if (!renderer->node()->isElementNode()) 83 if (!renderer->node()->isElementNode())
76 return false; 84 return false;
77 if (renderer->style() && !renderer->style()->flowThread().isEmpty()) 85 if (renderer->style() && !renderer->style()->flowThread().isEmpty())
78 return true; 86 return true;
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 newRenderer->setFlowThreadState(parentRenderer->flowThreadState()); 319 newRenderer->setFlowThreadState(parentRenderer->flowThreadState());
312 320
313 RenderObject* nextRenderer = this->nextRenderer(); 321 RenderObject* nextRenderer = this->nextRenderer();
314 textNode->setRenderer(newRenderer); 322 textNode->setRenderer(newRenderer);
315 // Parent takes care of the animations, no need to call setAnimatableStyle. 323 // Parent takes care of the animations, no need to call setAnimatableStyle.
316 newRenderer->setStyle(m_style.release()); 324 newRenderer->setStyle(m_style.release());
317 parentRenderer->addChild(newRenderer, nextRenderer); 325 parentRenderer->addChild(newRenderer, nextRenderer);
318 } 326 }
319 327
320 } 328 }
OLDNEW
« no previous file with comments | « Source/core/dom/NodeRenderingContext.h ('k') | Source/core/dom/PseudoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698