Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 16589002: Reland: Fix errors when building android with coverage=1 (Closed)

Created:
7 years, 6 months ago by Isaac (away)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, rwalker
Visibility:
Public.

Description

Reland: Fix errors when building android with coverage=1 Originally landed in r204547 Reverted in r204553 due to cq anomaly. Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 TBR=willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M base/linux_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/16589002/1
7 years, 6 months ago (2013-06-06 19:51:57 UTC) #1
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-06 19:51:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/16589002/1
7 years, 6 months ago (2013-06-06 20:00:55 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 23:49:34 UTC) #4
Message was sent while issue was closed.
Change committed as 204662

Powered by Google App Engine
This is Rietveld 408576698