Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3139)

Unified Diff: chrome/browser/about_flags.cc

Issue 1658723007: Prototype handling of Intents in Custom Tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Histogram for unit test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index d05d6dc471928bf8de3203c8a4425cf0e3b13bc9..a6eeff537b732795c06d2c87291a5546eba488b3 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -521,6 +521,14 @@ const FeatureEntry::Choice kEnableOfflinePagesChoices[] = {
{IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages,
""},
};
+
+const FeatureEntry::Choice kHerbPrototypeChoices[] = {
+ {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, "", ""},
+ {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ANISE, switches::kHerbFlavor, "anise"},
+ {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL, switches::kHerbFlavor, "basil"},
+ {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE, switches::kHerbFlavor, "chive"},
+ {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_DILL, switches::kHerbFlavor, "dill"},
+};
#endif // defined(OS_ANDROID)
// RECORDING USER METRICS FOR FLAGS:
@@ -2043,6 +2051,10 @@ const FeatureEntry kFeatureEntries[] = {
autofill::switches::kDisableOfferUploadCreditCards)},
#endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
#if defined(OS_ANDROID)
+ {"herb-prototype-choices",
+ IDS_FLAGS_HERB_PROTOTYPE_CHOICES_NAME,
+ IDS_FLAGS_HERB_PROTOTYPE_CHOICES_DESCRIPTION, kOsAndroid,
+ MULTI_VALUE_TYPE(kHerbPrototypeChoices)},
{"enable-tab-switcher-in-document-mode",
IDS_FLAGS_TAB_SWITCHER_IN_DOCUMENT_MODE_NAME,
IDS_FLAGS_TAB_SWITCHER_IN_DOCUMENT_MODE_DESCRIPTION, kOsAndroid,
@@ -2187,6 +2199,14 @@ bool SkipConditionalFeatureEntry(const FeatureEntry& entry) {
channel != version_info::Channel::UNKNOWN) {
return true;
}
+ // enable-herb-prototype is only available for local, Canary, and Dev channel
+ // builds.
+ if (!strcmp(switches::kHerbFlavor, entry.internal_name) &&
+ channel != version_info::Channel::DEV &&
+ channel != version_info::Channel::CANARY &&
+ channel != version_info::Channel::UNKNOWN) {
+ return true;
+ }
// enable-tab-switcher-in-document-mode is only available for Chromium
// builds and the Canary channel.
if (!strcmp("enable-tab-switcher-in-document-mode",

Powered by Google App Engine
This is Rietveld 408576698