Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1658723007: Prototype handling of Intents in Custom Tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Histogram update Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 #if defined(OS_ANDROID) 514 #if defined(OS_ANDROID)
515 const FeatureEntry::Choice kEnableOfflinePagesChoices[] = { 515 const FeatureEntry::Choice kEnableOfflinePagesChoices[] = {
516 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 516 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
517 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS, 517 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS,
518 switches::kEnableOfflinePagesAsBookmarks, ""}, 518 switches::kEnableOfflinePagesAsBookmarks, ""},
519 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES, 519 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES,
520 switches::kEnableOfflinePagesAsSavedPages, ""}, 520 switches::kEnableOfflinePagesAsSavedPages, ""},
521 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages, 521 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages,
522 ""}, 522 ""},
523 }; 523 };
524
525 const FeatureEntry::Choice kHerbPrototypeChoices[] = {
526 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, "", ""},
527 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_ANISE,
528 switches::kTabManagementExperimentType, "anise"},
529 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_BASIL,
530 switches::kTabManagementExperimentType, "basil"},
531 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_CHIVE,
532 switches::kTabManagementExperimentType, "chive"},
533 {IDS_FLAGS_HERB_PROTOTYPE_FLAVOR_DILL,
534 switches::kTabManagementExperimentType, "dill"},
535 };
524 #endif // defined(OS_ANDROID) 536 #endif // defined(OS_ANDROID)
525 537
526 // RECORDING USER METRICS FOR FLAGS: 538 // RECORDING USER METRICS FOR FLAGS:
527 // ----------------------------------------------------------------------------- 539 // -----------------------------------------------------------------------------
528 // The first line of the entry is the internal name. If you'd like to gather 540 // The first line of the entry is the internal name. If you'd like to gather
529 // statistics about the usage of your flag, you should append a marker comment 541 // statistics about the usage of your flag, you should append a marker comment
530 // to the end of the feature name, like so: 542 // to the end of the feature name, like so:
531 // "my-special-feature", // FLAGS:RECORD_UMA 543 // "my-special-feature", // FLAGS:RECORD_UMA
532 // 544 //
533 // After doing that, run 545 // After doing that, run
(...skipping 1502 matching lines...) Expand 10 before | Expand all | Expand 10 after
2036 #if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID) 2048 #if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
2037 {"enable-autofill-credit-card-upload", 2049 {"enable-autofill-credit-card-upload",
2038 IDS_FLAGS_AUTOFILL_CREDIT_CARD_UPLOAD_NAME, 2050 IDS_FLAGS_AUTOFILL_CREDIT_CARD_UPLOAD_NAME,
2039 IDS_FLAGS_AUTOFILL_CREDIT_CARD_UPLOAD_DESCRIPTION, 2051 IDS_FLAGS_AUTOFILL_CREDIT_CARD_UPLOAD_DESCRIPTION,
2040 kOsCrOS | kOsWin | kOsLinux | kOsAndroid, 2052 kOsCrOS | kOsWin | kOsLinux | kOsAndroid,
2041 ENABLE_DISABLE_VALUE_TYPE( 2053 ENABLE_DISABLE_VALUE_TYPE(
2042 autofill::switches::kEnableOfferUploadCreditCards, 2054 autofill::switches::kEnableOfferUploadCreditCards,
2043 autofill::switches::kDisableOfferUploadCreditCards)}, 2055 autofill::switches::kDisableOfferUploadCreditCards)},
2044 #endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID) 2056 #endif // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
2045 #if defined(OS_ANDROID) 2057 #if defined(OS_ANDROID)
2058 {"tab-management-experiment-type",
2059 IDS_FLAGS_HERB_PROTOTYPE_CHOICES_NAME,
2060 IDS_FLAGS_HERB_PROTOTYPE_CHOICES_DESCRIPTION, kOsAndroid,
2061 MULTI_VALUE_TYPE(kHerbPrototypeChoices)},
2046 {"enable-tab-switcher-in-document-mode", 2062 {"enable-tab-switcher-in-document-mode",
2047 IDS_FLAGS_TAB_SWITCHER_IN_DOCUMENT_MODE_NAME, 2063 IDS_FLAGS_TAB_SWITCHER_IN_DOCUMENT_MODE_NAME,
2048 IDS_FLAGS_TAB_SWITCHER_IN_DOCUMENT_MODE_DESCRIPTION, kOsAndroid, 2064 IDS_FLAGS_TAB_SWITCHER_IN_DOCUMENT_MODE_DESCRIPTION, kOsAndroid,
2049 SINGLE_VALUE_TYPE(switches::kEnableTabSwitcherInDocumentMode)}, 2065 SINGLE_VALUE_TYPE(switches::kEnableTabSwitcherInDocumentMode)},
2050 #endif // OS_ANDROID 2066 #endif // OS_ANDROID
2051 {"enable-md-history", 2067 {"enable-md-history",
2052 IDS_FLAGS_ENABLE_MATERIAL_DESIGN_HISTORY_NAME, 2068 IDS_FLAGS_ENABLE_MATERIAL_DESIGN_HISTORY_NAME,
2053 IDS_FLAGS_ENABLE_MATERIAL_DESIGN_HISTORY_DESCRIPTION, 2069 IDS_FLAGS_ENABLE_MATERIAL_DESIGN_HISTORY_DESCRIPTION,
2054 kOsDesktop | kOsAndroid, 2070 kOsDesktop | kOsAndroid,
2055 SINGLE_VALUE_TYPE(switches::kEnableMaterialDesignHistory)}, 2071 SINGLE_VALUE_TYPE(switches::kEnableMaterialDesignHistory)},
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
2180 } 2196 }
2181 // enable-data-reduction-proxy-carrier-test is only available for Chromium 2197 // enable-data-reduction-proxy-carrier-test is only available for Chromium
2182 // builds and the Canary/Dev channel. 2198 // builds and the Canary/Dev channel.
2183 if (!strcmp("enable-data-reduction-proxy-carrier-test", 2199 if (!strcmp("enable-data-reduction-proxy-carrier-test",
2184 entry.internal_name) && 2200 entry.internal_name) &&
2185 channel != version_info::Channel::DEV && 2201 channel != version_info::Channel::DEV &&
2186 channel != version_info::Channel::CANARY && 2202 channel != version_info::Channel::CANARY &&
2187 channel != version_info::Channel::UNKNOWN) { 2203 channel != version_info::Channel::UNKNOWN) {
2188 return true; 2204 return true;
2189 } 2205 }
2206 // Tab management prototypes are only available for local, Canary, and Dev
2207 // channel builds.
2208 if (!strcmp("tab-management-experiment-type", entry.internal_name) &&
2209 channel != version_info::Channel::DEV &&
2210 channel != version_info::Channel::CANARY &&
2211 channel != version_info::Channel::UNKNOWN) {
2212 return true;
2213 }
2190 // enable-tab-switcher-in-document-mode is only available for Chromium 2214 // enable-tab-switcher-in-document-mode is only available for Chromium
2191 // builds and the Canary channel. 2215 // builds and the Canary channel.
2192 if (!strcmp("enable-tab-switcher-in-document-mode", 2216 if (!strcmp("enable-tab-switcher-in-document-mode",
2193 entry.internal_name) && 2217 entry.internal_name) &&
2194 channel != version_info::Channel::CANARY && 2218 channel != version_info::Channel::CANARY &&
2195 channel != version_info::Channel::UNKNOWN) { 2219 channel != version_info::Channel::UNKNOWN) {
2196 return true; 2220 return true;
2197 } 2221 }
2198 #endif 2222 #endif
2199 2223
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
2345 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2369 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2346 2370
2347 const FeatureEntry* GetFeatureEntries(size_t* count) { 2371 const FeatureEntry* GetFeatureEntries(size_t* count) {
2348 *count = arraysize(kFeatureEntries); 2372 *count = arraysize(kFeatureEntries);
2349 return kFeatureEntries; 2373 return kFeatureEntries;
2350 } 2374 }
2351 2375
2352 } // namespace testing 2376 } // namespace testing
2353 2377
2354 } // namespace about_flags 2378 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698