Prototype handling of Intents in Custom Tabs

Prototype handling of Intents in Custom Tabs

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
Committed: https://crrev.com/d60de5c9c1bd04ea14d561bf3513c45fba94ca21
Cr-Commit-Position: refs/heads/master@{#373303}

[gone, 2016-02-01 23:15:31]

Description was changed from

==========
Prototype handling of Intents in CCT

* Add a flag to about:flags that's restricted to Dev and lower that enables
  UI experiments.

* Send VIEW Intents that don't have NEW_TASK or NEW_DOCUMENT to Custom Tabs
  instead of Chrome proper.

BUG=582539
==========

to

==========
Prototype handling of Intents in CCT

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't 
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
==========

[gone, 2016-02-01 23:15:31]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2016-02-01 23:17:23]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2016-02-01 23:17:24]

Ian: Please review the stuff about CCT triggering.
Ted: Please review anything related to enabling plant mode.

[Ian Wen, 2016-02-02 01:24:37]

CCT lgtm.

https://chromiumcodereview.appspot.com/1658723007/diff/40001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/1658723007/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:859:
* and stores them in SharedPreferences. Because of when this function is called,
the browser
Remove "of"?

[gone, 2016-02-02 01:59:42]

Same CL, now with more flavors.

https://chromiumcodereview.appspot.com/1658723007/diff/40001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/1658723007/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:859:
* and stores them in SharedPreferences. Because of when this function is called,
the browser
On 2016/02/02 01:24:37, Ian Wen wrote:
> Remove "of"?

Reworded it.

https://chromiumcodereview.appspot.com/1658723007/diff/80001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/1658723007/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:859:
* library has loaded, they won't affect the next launch until Chrome is
restarted.
Ted: I didn't make this function cause a reboot because of _when_ this could
potentially trigger.  It could look like we'd crashed (maybe with an Android
popup saying so) and then immediately restarted Chrome.

[Ted C, 2016-02-02 21:22:46]

lgtm

https://codereview.chromium.org/1658723007/diff/80001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://codereview.chromium.org/1658723007/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:859:
* library has loaded, they won't affect the next launch until Chrome is
restarted.
On 2016/02/02 01:59:42, dfalcantara wrote:
> Ted: I didn't make this function cause a reboot because of _when_ this could
> potentially trigger.  It could look like we'd crashed (maybe with an Android
> popup saying so) and then immediately restarted Chrome.

We might want to put a temporary toast in here telling them to restart again
(non-translated, super short term, etc..)

[gone, 2016-02-02 22:00:23]

Ted: does this string make sense?

[gone, 2016-02-02 22:07:28]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-02-02 22:07:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org,
tedchoc@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1658723007/#ps140001 (title: "Added
toast")

[commit-bot: I haz the power, 2016-02-02 22:11:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1658723007/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1658723007/140001

[gone, 2016-02-03 00:02:53]

Description was changed from

==========
Prototype handling of Intents in CCT

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't 
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
==========

to

==========
Prototype handling of Intents in Custom Tabs

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't 
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
==========

[gone, 2016-02-03 00:03:21]

dfalcantara@chromium.org changed reviewers:
+ isherman@chromium.org

[gone, 2016-02-03 00:03:22]

+isherman@ for histogram change required by unit test.

[Ilya Sherman, 2016-02-03 01:13:21]

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
tools/metrics/histograms/histograms.xml:70313: +  <int value="-814923711"
label="herb-flavor"/>
LGTM, though this is a ... really unclear flag name.  It's cute, but it will
make crash reports and whatnot that much harder to understand.  Just sayin'.

[gone, 2016-02-03 01:18:28]

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
tools/metrics/histograms/histograms.xml:70313: +  <int value="-814923711"
label="herb-flavor"/>
On 2016/02/03 01:13:21, Ilya Sherman wrote:
> LGTM, though this is a ... really unclear flag name.  It's cute, but it will
> make crash reports and whatnot that much harder to understand.  Just sayin'.

Yeah, it's really meant to be an internal team-only flag for some
quick-and-dirty Android N UI prototyping.  It isn't really meant to be checked
for in crash reports.  The flag isn't going to live past M50/M51, but I can swap
it to something else if you prefer.

[Ilya Sherman, 2016-02-03 01:27:04]

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
tools/metrics/histograms/histograms.xml:70313: +  <int value="-814923711"
label="herb-flavor"/>
On 2016/02/03 01:18:28, dfalcantara wrote:
> On 2016/02/03 01:13:21, Ilya Sherman wrote:
> > LGTM, though this is a ... really unclear flag name.  It's cute, but it will
> > make crash reports and whatnot that much harder to understand.  Just sayin'.
> 
> Yeah, it's really meant to be an internal team-only flag for some
> quick-and-dirty Android N UI prototyping.  It isn't really meant to be checked
> for in crash reports.  The flag isn't going to live past M50/M51, but I can
swap
> it to something else if you prefer.

Eh, I don't super mind either way.  But, all else equal, I do prefer clearer
flag names =)

[gone, 2016-02-03 01:57:28]

I'm still compiling the unit test so that it can fail and I can get the updated
histogram value, but is the new patch alright aside from that?  I'll update the
CL once that's run.

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1658723007/diff/160001/tools/metrics/h...
tools/metrics/histograms/histograms.xml:70313: +  <int value="-814923711"
label="herb-flavor"/>
On 2016/02/03 01:27:04, Ilya Sherman wrote:
> On 2016/02/03 01:18:28, dfalcantara wrote:
> > On 2016/02/03 01:13:21, Ilya Sherman wrote:
> > > LGTM, though this is a ... really unclear flag name.  It's cute, but it
will
> > > make crash reports and whatnot that much harder to understand.  Just
sayin'.
> > 
> > Yeah, it's really meant to be an internal team-only flag for some
> > quick-and-dirty Android N UI prototyping.  It isn't really meant to be
checked
> > for in crash reports.  The flag isn't going to live past M50/M51, but I can
> swap
> > it to something else if you prefer.
> 
> Eh, I don't super mind either way.  But, all else equal, I do prefer clearer
> flag names =)

How's this new patch look?  Switched to "tab-management-experiment-type" for the
flag, but kept using the name Herb everywhere in the code because it's a
mouthful.

[gone, 2016-02-03 02:10:49]

Swapped in the new histogram value.  PTAL, thanks!

[Ilya Sherman, 2016-02-03 19:22:59]

LGTM, thanks.

[gone, 2016-02-03 19:23:54]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-02-03 19:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, ianwen@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1658723007/#ps200001 (title: "Histogram
update")

[commit-bot: I haz the power, 2016-02-03 19:25:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1658723007/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1658723007/200001

[commit-bot: I haz the power, 2016-02-03 19:37:00]

Description was changed from

==========
Prototype handling of Intents in Custom Tabs

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't 
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
==========

to

==========
Prototype handling of Intents in Custom Tabs

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't 
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
==========

[commit-bot: I haz the power, 2016-02-03 19:37:01]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-02-03 19:38:31]

Description was changed from

==========
Prototype handling of Intents in Custom Tabs

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't 
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539
==========

to

==========
Prototype handling of Intents in Custom Tabs

* Add a flag to about:flags that's restricted to Dev and
  lower that enables UI experiments.

* Cache the new native flags from about:flags inside of
  SharedPreferences.  This is necessary because we don't
  have access to the native side early on when
  ChromeLauncherActivity is triggered.

* Send VIEW Intents that don't have NEW_TASK or
  NEW_DOCUMENT to Custom Tabs instead of Chrome proper.

BUG=582539

Committed: https://crrev.com/d60de5c9c1bd04ea14d561bf3513c45fba94ca21
Cr-Commit-Position: refs/heads/master@{#373303}
==========

[commit-bot: I haz the power, 2016-02-03 19:38:32]

Patchset 11 (id:??) landed as
https://crrev.com/d60de5c9c1bd04ea14d561bf3513c45fba94ca21
Cr-Commit-Position: refs/heads/master@{#373303}