Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 16583003: Error recovery for valid media query followed by garbage. (Closed)

Created:
7 years, 6 months ago by rune
Modified:
7 years, 6 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Error recovery for valid media query followed by garbage. Remaining issue after r151842. The "error rule_error_recovery" production would not trigger in this case since a valid_media_query would be reduced to a media_query not taking the following tokens into account. BUG=247510 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152112

Patch Set 1 #

Patch Set 2 : Added missing comma in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M LayoutTests/fast/media/media-query-list-syntax.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/fast/media/media-query-list-syntax-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSGrammar.y.in View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rune
7 years, 6 months ago (2013-06-06 22:48:53 UTC) #1
SeRya
lgtm
7 years, 6 months ago (2013-06-07 03:27:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/16583003/1
7 years, 6 months ago (2013-06-07 05:26:11 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1303
7 years, 6 months ago (2013-06-07 05:35:51 UTC) #4
rune
Too quick, there. Thought SeRya's stamp was enough.
7 years, 6 months ago (2013-06-07 07:27:35 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 6 months ago (2013-06-08 10:28:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/16583003/10001
7 years, 6 months ago (2013-06-08 18:33:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=12052
7 years, 6 months ago (2013-06-08 19:27:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/16583003/10001
7 years, 6 months ago (2013-06-10 08:22:27 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 08:56:12 UTC) #10
Message was sent while issue was closed.
Change committed as 152112

Powered by Google App Engine
This is Rietveld 408576698