Issue 16580009: Change touch selection handles to images given by UX.

Issue 16580009: Change touch selection handles to images given by UX. (Closed)

Created:
7 years, 6 months ago by varunjain

Modified:
7 years, 6 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change touch selection handles to images given by UX. BUG=239097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205119

Patch Set 4 : rebased #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -52 lines)			Patch
M	content/browser/web_contents/touch_editable_impl_aura_browsertest.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl.cc	View	1 2	13 chunks	+64 lines, -46 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl_unittest.cc	View	1 2 3	6 chunks	+25 lines, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM https://codereview.chromium.org/16580009/diff/1/ui/views/touchui/touch_selection_controller_impl.cc File ui/views/touchui/touch_selection_controller_impl.cc (right): https://codereview.chromium.org/16580009/diff/1/ui/views/touchui/touch_selection_controller_impl.cc#newcode54 ui/views/touchui/touch_selection_controller_impl.cc:54: handle_image = &ui::ResourceBundle::GetSharedInstance().GetImageNamed( indentation is off here. https://codereview.chromium.org/16580009/diff/1/ui/views/touchui/touch_selection_controller_impl.cc#newcode331 ...

7 years, 6 months ago (2013-06-07 02:19:10 UTC) #2

varunjain

https://codereview.chromium.org/16580009/diff/1/ui/views/touchui/touch_selection_controller_impl.cc File ui/views/touchui/touch_selection_controller_impl.cc (right): https://codereview.chromium.org/16580009/diff/1/ui/views/touchui/touch_selection_controller_impl.cc#newcode54 ui/views/touchui/touch_selection_controller_impl.cc:54: handle_image = &ui::ResourceBundle::GetSharedInstance().GetImageNamed( On 2013/06/07 02:19:10, sadrul wrote: > ...

7 years, 6 months ago (2013-06-07 06:09:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/16580009/10001

7 years, 6 months ago (2013-06-07 17:20:47 UTC) #6

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=159754

7 years, 6 months ago (2013-06-07 21:01:42 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/16580009/34001

7 years, 6 months ago (2013-06-09 06:49:35 UTC) #8

Message was sent while issue was closed.

Change committed as 205119

Expand Messages | Collapse Messages