Adding YUVA support for enabling Alpha Playback

Adding YUVA support for enabling Alpha Playback

Adding YUVA support for enabling VP8 Alpha Playback. Trying to reland
the change that was reverted earlier.

Old CL: https://codereview.chromium.org/12157002/

BUG=147355
TBR=jschuh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204944

[vignesh, 2013-06-06 21:38:29]

Fixing the heap corruption bug in linux asan.

PTAL, so that i can try and land this.

[enne (OOO), 2013-06-06 21:40:26]

On 2013/06/06 21:38:29, vignesh wrote:
> Fixing the heap corruption bug in linux asan.
> 
> PTAL, so that i can try and land this.

Where's the diff?

[vignesh, 2013-06-07 02:22:22]

really sorry about forgetting to upload the state in which it failed. I have
uploaded the state in which it failed as patch set 2, and patch set 3 has the
fix. Please look into the delta between patch sets 2 and 3 for the diff. Ignore
patchset 1.

[piman, 2013-06-07 02:56:22]

https://codereview.chromium.org/16580006/diff/6001/cc/output/renderer_pixelte...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/16580006/diff/6001/cc/output/renderer_pixelte...
cc/output/renderer_pixeltest.cc:257: gfx::Rect uv_rect((w + 1) / 2, (h + 1) /
2);
Can you move this before  uv_plane_size, and make  uv_plane_size =
uv_rect.size().GetArea();
That way you prevent any problem in the future.

[enne (OOO), 2013-06-07 02:56:32]

Thanks for uploading both sets of patches.

lgtm

https://codereview.chromium.org/16580006/diff/6001/cc/output/renderer_pixelte...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/16580006/diff/6001/cc/output/renderer_pixelte...
cc/output/renderer_pixeltest.cc:257: gfx::Rect uv_rect((w + 1) / 2, (h + 1) /
2);
Consider moving uv_rect's declaration above uv_plane_size and making
uv_plane_size just equal to its width * height.

[vignesh, 2013-06-07 04:17:03]

https://codereview.chromium.org/16580006/diff/6001/cc/output/renderer_pixelte...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/16580006/diff/6001/cc/output/renderer_pixelte...
cc/output/renderer_pixeltest.cc:257: gfx::Rect uv_rect((w + 1) / 2, (h + 1) /
2);
On 2013/06/07 02:56:23, piman wrote:
> Can you move this before  uv_plane_size, and make  uv_plane_size =
> uv_rect.size().GetArea();
> That way you prevent any problem in the future.

Done. Doing this as piman@ suggested.

[piman, 2013-06-07 04:23:24]

lgtm

[commit-bot: I haz the power, 2013-06-07 17:53:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/16580006/16001

[commit-bot: I haz the power, 2013-06-07 21:51:01]

Change committed as 204944