Issue 16574003: Converting applicable WebGraphicsContext3D functions to the GL macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16574003: Converting applicable WebGraphicsContext3D functions to the GL macros (Closed)

Created:
7 years, 6 months ago by bajones

Modified:
7 years, 6 months ago

Reviewers:
Ken Russell (switch to Gerrit), greggman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Converting applicable WebGraphicsContext3D functions to the GL macros BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204664

Patch Set 2 : Alignment tweak #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -176 lines)			Patch
	M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View	1	12 chunks	+124 lines, -176 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

greggman

lgtm https://codereview.chromium.org/16574003/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc (right): https://codereview.chromium.org/16574003/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc#newcode157 content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc:157: t4 a4) { \ do you want to ...

7 years, 6 months ago (2013-06-06 18:07:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/16574003/5001

7 years, 6 months ago (2013-06-06 20:45:39 UTC) #3

Message was sent while issue was closed.

Change committed as 204664

Expand Messages | Collapse Messages

Issue 16574003: Converting applicable WebGraphicsContext3D functions to the GL macros (Closed)

Description

Patch Set 1 #

Patch Set 2 : Alignment tweak #

Messages