Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1656223003: command_buffer_gles2: Avoid crashing for lack of JNI (Closed)

Created:
4 years, 10 months ago by Kimmo Kinnunen
Modified:
4 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer_gles2: Avoid crashing for lack of JNI Do not use Java environment to detect device model when command buffer is built as a standalone library. EGL API can not be used to pass the JNI from client to the library, and the client might not be a Java application anyway. BUG=skia:2992 Committed: https://crrev.com/ef49d533528742e7795c36fd717fd2b6a64c1627 Cr-Commit-Position: refs/heads/master@{#373195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M gpu/config/gpu_info_collector_android.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Kimmo Kinnunen
4 years, 10 months ago (2016-02-02 08:44:45 UTC) #2
piman
lgtm
4 years, 10 months ago (2016-02-02 16:49:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656223003/1
4 years, 10 months ago (2016-02-03 06:29:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 07:47:07 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 07:47:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef49d533528742e7795c36fd717fd2b6a64c1627
Cr-Commit-Position: refs/heads/master@{#373195}

Powered by Google App Engine
This is Rietveld 408576698