chrome/browser/extensions/extension_url_rewrite_browsertest.cc - Issue 16561007: Use a direct include of utf_string_conversions.h in chrome/browser/, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_url_rewrite_browsertest.cc

Issue 16561007: Use a direct include of utf_string_conversions.h in chrome/browser/, part 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/process_util.h"	5 #include "base/process_util.h"

6 #include "base/strings/sys_string_conversions.h"	6 #include "base/strings/sys_string_conversions.h"

7 #include "base/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #include "chrome/browser/extensions/component_loader.h"	8 #include "chrome/browser/extensions/component_loader.h"

9 #include "chrome/browser/extensions/extension_browsertest.h"	9 #include "chrome/browser/extensions/extension_browsertest.h"

10 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

11 #include "chrome/browser/ui/browser_window.h"	11 #include "chrome/browser/ui/browser_window.h"

12 #include "chrome/browser/ui/omnibox/location_bar.h"	12 #include "chrome/browser/ui/omnibox/location_bar.h"

13 #include "chrome/browser/ui/omnibox/omnibox_view.h"	13 #include "chrome/browser/ui/omnibox/omnibox_view.h"

14 #include "chrome/browser/ui/tabs/tab_strip_model.h"	14 #include "chrome/browser/ui/tabs/tab_strip_model.h"

15 #include "chrome/common/url_constants.h"	15 #include "chrome/common/url_constants.h"

16 #include "chrome/test/base/in_process_browser_test.h"	16 #include "chrome/test/base/in_process_browser_test.h"

17 #include "chrome/test/base/testing_profile.h"	17 #include "chrome/test/base/testing_profile.h"

(...skipping 109 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
127 TestExtensionURLOverride(url_with_ref);	127 TestExtensionURLOverride(url_with_ref);

128 }	128 }

129	129

130 IN_PROC_BROWSER_TEST_F(ExtensionURLRewriteBrowserTest, BookmarksURLOverride) {	130 IN_PROC_BROWSER_TEST_F(ExtensionURLRewriteBrowserTest, BookmarksURLOverride) {

131 // Load an extension that overrides chrome://bookmarks.	131 // Load an extension that overrides chrome://bookmarks.

132 ASSERT_TRUE(LoadExtension(GetTestExtensionPath("bookmarks")));	132 ASSERT_TRUE(LoadExtension(GetTestExtensionPath("bookmarks")));

133 // Navigate to chrome://bookmarks and check that the location bar URL is what	133 // Navigate to chrome://bookmarks and check that the location bar URL is what

134 // was entered and the internal URL uses the chrome-extension:// scheme.	134 // was entered and the internal URL uses the chrome-extension:// scheme.

135 TestExtensionURLOverride(GURL(chrome::kChromeUIBookmarksURL));	135 TestExtensionURLOverride(GURL(chrome::kChromeUIBookmarksURL));

136 }	136 }

OLD	NEW