Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/devtools/front_end/DOMBreakpointsSidebarPane.js

Issue 16561003: DevTools: Inspect element mode does not select element in ShadowDOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 } 146 }
147 WebInspector.formatLocalized(message, substitutions, formatters, "", app end); 147 WebInspector.formatLocalized(message, substitutions, formatters, "", app end);
148 148
149 callback(element); 149 callback(element);
150 }, 150 },
151 151
152 _nodeRemoved: function(event) 152 _nodeRemoved: function(event)
153 { 153 {
154 var node = event.data.node; 154 var node = event.data.node;
155 this._removeBreakpointsForNode(event.data.node); 155 this._removeBreakpointsForNode(event.data.node);
156 if (!node.children) 156 var children = node.children();
157 if (!children)
157 return; 158 return;
158 for (var i = 0; i < node.children.length; ++i) 159 for (var i = 0; i < children.length; ++i)
159 this._removeBreakpointsForNode(node.children[i]); 160 this._removeBreakpointsForNode(children[i]);
160 this._saveBreakpoints(); 161 this._saveBreakpoints();
161 }, 162 },
162 163
163 _removeBreakpointsForNode: function(node) 164 _removeBreakpointsForNode: function(node)
164 { 165 {
165 for (var id in this._breakpointElements) { 166 for (var id in this._breakpointElements) {
166 var element = this._breakpointElements[id]; 167 var element = this._breakpointElements[id];
167 if (element._node === node) 168 if (element._node === node)
168 this._removeBreakpoint(element._node, element._type); 169 this._removeBreakpoint(element._node, element._type);
169 } 170 }
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 this.element.appendChild(this.bodyElement); 394 this.element.appendChild(this.bodyElement);
394 }, 395 },
395 396
396 __proto__: WebInspector.SidebarPane.prototype 397 __proto__: WebInspector.SidebarPane.prototype
397 } 398 }
398 399
399 /** 400 /**
400 * @type {?WebInspector.DOMBreakpointsSidebarPane} 401 * @type {?WebInspector.DOMBreakpointsSidebarPane}
401 */ 402 */
402 WebInspector.domBreakpointsSidebarPane = null; 403 WebInspector.domBreakpointsSidebarPane = null;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698