Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 16556002: Assign less environments in StoreNamedField (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2276 matching lines...) Expand 10 before | Expand all | Expand 10 after
2287 } else { 2287 } else {
2288 val = UseRegister(instr->value()); 2288 val = UseRegister(instr->value());
2289 } 2289 }
2290 2290
2291 // We only need a scratch register if we have a write barrier or we 2291 // We only need a scratch register if we have a write barrier or we
2292 // have a store into the properties array (not in-object-property). 2292 // have a store into the properties array (not in-object-property).
2293 LOperand* temp = (!is_in_object || needs_write_barrier || 2293 LOperand* temp = (!is_in_object || needs_write_barrier ||
2294 needs_write_barrier_for_map) ? TempRegister() : NULL; 2294 needs_write_barrier_for_map) ? TempRegister() : NULL;
2295 2295
2296 LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp); 2296 LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp);
2297 if ((FLAG_track_fields && instr->field_representation().IsSmi()) || 2297 if (FLAG_track_heap_object_fields &&
2298 (FLAG_track_heap_object_fields && 2298 instr->field_representation().IsHeapObject()) {
2299 instr->field_representation().IsHeapObject())) { 2299 if (!instr->value()->type().IsHeapObject()) {
2300 return AssignEnvironment(result); 2300 return AssignEnvironment(result);
2301 }
2301 } 2302 }
2302 return result; 2303 return result;
2303 } 2304 }
2304 2305
2305 2306
2306 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2307 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2307 LOperand* object = UseFixed(instr->object(), rdx); 2308 LOperand* object = UseFixed(instr->object(), rdx);
2308 LOperand* value = UseFixed(instr->value(), rax); 2309 LOperand* value = UseFixed(instr->value(), rax);
2309 2310
2310 LStoreNamedGeneric* result = new(zone()) LStoreNamedGeneric(object, value); 2311 LStoreNamedGeneric* result = new(zone()) LStoreNamedGeneric(object, value);
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
2574 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2575 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2575 LOperand* object = UseRegister(instr->object()); 2576 LOperand* object = UseRegister(instr->object());
2576 LOperand* index = UseTempRegister(instr->index()); 2577 LOperand* index = UseTempRegister(instr->index());
2577 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2578 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2578 } 2579 }
2579 2580
2580 2581
2581 } } // namespace v8::internal 2582 } } // namespace v8::internal
2582 2583
2583 #endif // V8_TARGET_ARCH_X64 2584 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698