Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 16556002: Assign less environments in StoreNamedField (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2336 matching lines...) Expand 10 before | Expand all | Expand 10 after
2347 instr->field_representation().IsDouble()) { 2347 instr->field_representation().IsDouble()) {
2348 val = UseRegisterAtStart(instr->value()); 2348 val = UseRegisterAtStart(instr->value());
2349 } else { 2349 } else {
2350 val = UseRegister(instr->value()); 2350 val = UseRegister(instr->value());
2351 } 2351 }
2352 2352
2353 // We need a temporary register for write barrier of the map field. 2353 // We need a temporary register for write barrier of the map field.
2354 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2354 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2355 2355
2356 LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp); 2356 LStoreNamedField* result = new(zone()) LStoreNamedField(obj, val, temp);
2357 if ((FLAG_track_fields && instr->field_representation().IsSmi()) || 2357 if (FLAG_track_heap_object_fields &&
2358 (FLAG_track_heap_object_fields && 2358 instr->field_representation().IsHeapObject()) {
2359 instr->field_representation().IsHeapObject())) { 2359 if (!instr->value()->type().IsHeapObject()) {
2360 return AssignEnvironment(result); 2360 return AssignEnvironment(result);
2361 }
2361 } 2362 }
2362 return result; 2363 return result;
2363 } 2364 }
2364 2365
2365 2366
2366 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 2367 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
2367 LOperand* obj = UseFixed(instr->object(), r1); 2368 LOperand* obj = UseFixed(instr->object(), r1);
2368 LOperand* val = UseFixed(instr->value(), r0); 2369 LOperand* val = UseFixed(instr->value(), r0);
2369 2370
2370 LInstruction* result = new(zone()) LStoreNamedGeneric(obj, val); 2371 LInstruction* result = new(zone()) LStoreNamedGeneric(obj, val);
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
2631 2632
2632 2633
2633 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2634 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2634 LOperand* object = UseRegister(instr->object()); 2635 LOperand* object = UseRegister(instr->object());
2635 LOperand* index = UseRegister(instr->index()); 2636 LOperand* index = UseRegister(instr->index());
2636 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2637 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2637 } 2638 }
2638 2639
2639 2640
2640 } } // namespace v8::internal 2641 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698