Add use_spring_wallpaper flag for Spring default wallpaper

Add use_spring_wallpaper flag for Spring default wallpaper


BUG=247072
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204682

[bshe, 2013-06-06 19:08:16]

Hi Steven.

This is the chrome side code. I will need a use_spring_wallpaper to decide which
wallpaper to use.

[bshe, 2013-06-06 19:10:40]

The actual resources(spring.jpgs) will be uploaded in a seperate CL.

[stevenjb, 2013-06-06 19:50:02]

https://codereview.chromium.org/16544004/diff/5001/ash/resources/ash_wallpape...
File ash/resources/ash_wallpaper_resources.grd (right):

https://codereview.chromium.org/16544004/diff/5001/ash/resources/ash_wallpape...
ash/resources/ash_wallpaper_resources.grd:30: </if>
This is pretty challenging to read, can we make this:
<if google_chrome>
  <if not use_oem and not use_spring>
    2-landscape8.jpg
  </if>
  <if use_oem and not use_spring>
    oem1.jpg
  </if>
  <if not use_oem and use_spring>
    spring.jpg
  </if>
</if>

[stevenjb, 2013-06-06 19:56:58]

LGTM with or without the suggested change

[James Cook, 2013-06-06 19:59:29]

LGTM for owners

[bshe, 2013-06-06 20:36:54]

Thanks for quick review.

https://codereview.chromium.org/16544004/diff/5001/ash/resources/ash_wallpape...
File ash/resources/ash_wallpaper_resources.grd (right):

https://codereview.chromium.org/16544004/diff/5001/ash/resources/ash_wallpape...
ash/resources/ash_wallpaper_resources.grd:30: </if>
done

On 2013/06/06 19:50:02, stevenjb (chromium) wrote:
> This is pretty challenging to read, can we make this:
> <if google_chrome>
>   <if not use_oem and not use_spring>
>     2-landscape8.jpg
>   </if>
>   <if use_oem and not use_spring>
>     oem1.jpg
>   </if>
>   <if not use_oem and use_spring>
>     spring.jpg
>   </if>
> </if>
> 
>

[commit-bot: I haz the power, 2013-06-06 21:33:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/16544004/15001

[commit-bot: I haz the power, 2013-06-07 00:55:21]

Change committed as 204682