Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 16544003: Skip batterystatus tests as Blink/Chromium does not yet support the API (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Skip batterystatus tests as Blink/Chromium does not yet support the API BUG=122593 TBR=ojan NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
7 years, 6 months ago (2013-06-06 18:25:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/16544003/1
7 years, 6 months ago (2013-06-06 18:26:34 UTC) #2
commit-bot: I haz the power
Change committed as 151954
7 years, 6 months ago (2013-06-06 18:26:44 UTC) #3
ojan
lgtm How about we delete these? I don't see an intent to implement on blink-dev, ...
7 years, 6 months ago (2013-06-06 18:45:44 UTC) #4
adamk
7 years, 6 months ago (2013-06-06 19:05:29 UTC) #5
Message was sent while issue was closed.
On 2013/06/06 18:45:44, ojan wrote:
> lgtm
> 
> How about we delete these? I don't see an intent to implement on blink-dev, so
> it seems there's noone actively working on exposing this.

See the attached bug. There has been recent interest both from Chrome OS and
Android about supporting this API in Chromium. I'm waiting to hear back from the
cros folks. While the code's in the tree, I think the tests should be, too.

Powered by Google App Engine
This is Rietveld 408576698