Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 16542003: Enable map dependency to in-flight compilation info. (Closed)

Created:
7 years, 6 months ago by Yang
Modified:
7 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Enable map dependency to in-flight compilation info. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15005

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : put transition maps and initial maps dependency into a separate CL #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -173 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M src/compiler.h View 7 chunks +46 lines, -7 lines 0 comments Download
M src/compiler.cc View 1 2 4 chunks +44 lines, -4 lines 1 comment Download
M src/hydrogen.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 29 chunks +51 lines, -48 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 chunks +17 lines, -9 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M src/mark-compact.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M src/objects.h View 1 2 4 chunks +25 lines, -7 lines 0 comments Download
M src/objects.cc View 1 2 5 chunks +97 lines, -14 lines 1 comment Download
M src/objects-inl.h View 1 2 2 chunks +25 lines, -16 lines 0 comments Download
M src/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M test/mjsunit/compiler/parallel-proto-change.js View 2 chunks +11 lines, -6 lines 0 comments Download
M test/mjsunit/manual-parallel-recompile.js View 2 chunks +13 lines, -5 lines 0 comments Download
M test/mjsunit/parallel-optimize-disabled.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 6 months ago (2013-06-06 11:49:44 UTC) #1
Yang
On 2013/06/06 11:49:44, Yang wrote: I've uploaded a second patch set to remove the changes ...
7 years, 6 months ago (2013-06-07 11:06:58 UTC) #2
ulan
LGTM https://codereview.chromium.org/16542003/diff/6001/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/16542003/diff/6001/src/compiler.cc#newcode146 src/compiler.cc:146: for (int j = 0; j < group_maps->length(); ...
7 years, 6 months ago (2013-06-07 13:21:29 UTC) #3
Yang
7 years, 6 months ago (2013-06-07 13:27:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698