Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16540002: Fixed compile_frontend.py warnings. (Closed)

Created:
7 years, 6 months ago by SeRya
Modified:
7 years, 6 months ago
Reviewers:
apavlov, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Fixed compile_frontend.py warnings. BUG=168776 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151963

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/devtools/front_end/DebuggerModel.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/IsolatedFileSystem.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
SeRya
7 years, 6 months ago (2013-06-06 10:41:36 UTC) #1
apavlov
Looks good, one syntax nit https://codereview.chromium.org/16540002/diff/1/Source/devtools/front_end/DebuggerModel.js File Source/devtools/front_end/DebuggerModel.js (right): https://codereview.chromium.org/16540002/diff/1/Source/devtools/front_end/DebuggerModel.js#newcode616 Source/devtools/front_end/DebuggerModel.js:616: * @param {Object=} opt_auxData ...
7 years, 6 months ago (2013-06-06 11:03:49 UTC) #2
SeRya
https://codereview.chromium.org/16540002/diff/1/Source/devtools/front_end/DebuggerModel.js File Source/devtools/front_end/DebuggerModel.js (right): https://codereview.chromium.org/16540002/diff/1/Source/devtools/front_end/DebuggerModel.js#newcode616 Source/devtools/front_end/DebuggerModel.js:616: * @param {Object=} opt_auxData On 2013/06/06 11:03:49, apavlov wrote: ...
7 years, 6 months ago (2013-06-06 11:25:54 UTC) #3
apavlov
lgtm
7 years, 6 months ago (2013-06-06 11:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/16540002/6001
7 years, 6 months ago (2013-06-06 11:30:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1224
7 years, 6 months ago (2013-06-06 11:41:50 UTC) #6
SeRya
Yury, your review needed.
7 years, 6 months ago (2013-06-06 12:40:03 UTC) #7
yurys
lgtm
7 years, 6 months ago (2013-06-06 13:22:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/16540002/6001
7 years, 6 months ago (2013-06-06 14:27:55 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8988
7 years, 6 months ago (2013-06-06 15:12:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/16540002/6001
7 years, 6 months ago (2013-06-06 15:22:57 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=9001
7 years, 6 months ago (2013-06-06 16:02:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/16540002/6001
7 years, 6 months ago (2013-06-06 18:34:44 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 20:47:02 UTC) #14
Message was sent while issue was closed. 
Change committed as 151963

Powered by Google App Engine
This is Rietveld 408576698