cc/raster/gpu_rasterizer.cc - Issue 1653983002: cc: Avoid extra flush calls to Skia GrContext

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/raster/gpu_rasterizer.cc

Issue 1653983002: cc: Avoid extra flush calls to Skia GrContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: eh Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/raster/gpu_rasterizer.h"	5 #include "cc/raster/gpu_rasterizer.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/metrics/histogram.h"	10 #include "base/metrics/histogram.h"

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72	72

73 SkSurface* sk_surface = write_lock->sk_surface();	73 SkSurface* sk_surface = write_lock->sk_surface();

74	74

75 // Allocating an SkSurface will fail after a lost context. Pretend we	75 // Allocating an SkSurface will fail after a lost context. Pretend we

76 // rasterized, as the contents of the resource don't matter anymore.	76 // rasterized, as the contents of the resource don't matter anymore.

77 if (!sk_surface)	77 if (!sk_surface)

78 return;	78 return;

79	79

80 SkMultiPictureDraw multi_picture_draw;	80 SkMultiPictureDraw multi_picture_draw;

81 multi_picture_draw.add(sk_surface->getCanvas(), picture.get());	81 multi_picture_draw.add(sk_surface->getCanvas(), picture.get());

82 multi_picture_draw.draw(msaa_sample_count_ > 0);	82 multi_picture_draw.draw(false);
	ericrk 2016/02/09 19:31:46 Not sure I follow the change here. I was saying th Not sure I follow the change here. I was saying that you may be able to just pass false here and leave the flush in EndGpuRaster... just setting false here I think misses necessary flushes. Feel free to move back to your previous approach.
83 write_lock->ReleaseSkSurface();	83 write_lock->ReleaseSkSurface();

84 }	84 }

85 }	85 }

86	86

87 } // namespace cc	87 } // namespace cc

OLD	NEW

« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/raster/scoped_gpu_raster.cc » ('j') | cc/resources/resource_provider.cc » ('J')