Clear button for date/time inputs should be zoomable

Clear button for date/time inputs should be zoomable on Mac

We will stop using NSCancelButtonCell and draw it using GraphicsContext.
This will also enable zooming for search field cancel buttons.

The change to RenderThemeChromiumMac::controlSizeForSystemFont fixes a bug where all controls were drawn with NSRegularControlSize when zoomed. Because we fixed this we had to introduce different padding depending on the control size (searchFieldHorizontalPaddings).

BUG=247572
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152845

[tkent, 2013-06-12 00:37:46]

We should do rebaseline for crbug.com/77779 before proceeding this CL.

https://codereview.chromium.org/16532002/diff/30001/Source/core/css/html.css
File Source/core/css/html.css (right):

https://codereview.chromium.org/16532002/diff/30001/Source/core/css/html.css#...
Source/core/css/html.css:450: -webkit-margin-start: 2px;
Why is this change needed?

https://codereview.chromium.org/16532002/diff/30001/Source/core/rendering/Ren...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/16532002/diff/30001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1645: Color fillColor(200, 200,
200);
This looks slightly lighter than the original according to the images in this
CL.
Color(186,186,186) ?

[keishi, 2013-06-13 08:45:41]

https://codereview.chromium.org/16532002/diff/30001/Source/core/css/html.css
File Source/core/css/html.css (right):

https://codereview.chromium.org/16532002/diff/30001/Source/core/css/html.css#...
Source/core/css/html.css:450: -webkit-margin-start: 2px;
On 2013/06/12 00:37:47, tkent wrote:
> Why is this change needed?

I am removing flex-start so the button is vertically centered.

RenderThemeChromiumMac::cancelButtonSizes() was returning sizes that were 2px
wider that the actual button. I fixed that and so we need to add the start
margin in CSS. (The margin start should have been 1px. I am changing that in the
next patch.)

This change is related because this patch fixes the font bug and we will be
drawing the cancel button in different sizes, I wanted the space between the
cancel button and the search field border to vary depending on the control size.
I'm doing that in searchFieldHorizontalPaddings().

https://codereview.chromium.org/16532002/diff/30001/Source/core/rendering/Ren...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/16532002/diff/30001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1645: Color fillColor(200, 200,
200);
On 2013/06/12 00:37:47, tkent wrote:
> This looks slightly lighter than the original according to the images in this
> CL.
> Color(186,186,186) ?

Color(200,200,200) matches the button drawn natively in Cocoa. I'm not sure why
it is drawn darker by WebKit.

[tkent, 2013-06-13 21:54:22]

fast/forms/search/search-appearance-basic.html requires rebaseline, doesn't it?

This CL updates some test results without the clear button. e.g.
week-suggestion-picker-appearance-rtl-expected.png.  What is changed?

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:742: if (zoomLevel != 1.0)
1.0 should be 1.

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1652: float centerX =
unzoomedRect.x() + unzoomedRect.width() / 2.0;
2.0 should be 2.

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1653: float centerY =
unzoomedRect.y() + unzoomedRect.height() / 2.0;
ditto.

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1658: float lineLength =
unzoomedRect.width() * 16 / 28;
Why isn't it 16.5?

[keishi, 2013-06-14 05:17:01]

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
File Source/core/rendering/RenderThemeChromiumMac.mm (right):

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:742: if (zoomLevel != 1.0)
On 2013/06/13 21:54:23, tkent wrote:
> 1.0 should be 1.

Done.

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1652: float centerX =
unzoomedRect.x() + unzoomedRect.width() / 2.0;
On 2013/06/13 21:54:23, tkent wrote:
> 2.0 should be 2.

Done.

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1653: float centerY =
unzoomedRect.y() + unzoomedRect.height() / 2.0;
On 2013/06/13 21:54:23, tkent wrote:
> ditto.

Done.

https://codereview.chromium.org/16532002/diff/64001/Source/core/rendering/Ren...
Source/core/rendering/RenderThemeChromiumMac.mm:1658: float lineLength =
unzoomedRect.width() * 16 / 28;
On 2013/06/13 21:54:23, tkent wrote:
> Why isn't it 16.5?

16.5px looked best in my vector illustration program, but Skia seems to draw
16px and 16.5 px the same. I've changed the comment to 16.5.

[tkent, 2013-06-14 05:22:18]

lgtm
Please makes sure TestExpectation has enough entries and build bots won't be
red.

[commit-bot: I haz the power, 2013-06-20 18:02:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/16532002/120001

[commit-bot: I haz the power, 2013-06-20 19:00:50]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-06-21 01:23:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/16532002/133001

[commit-bot: I haz the power, 2013-06-21 02:40:11]

Change committed as 152845