Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: Source/core/rendering/style/RenderStyle.h

Issue 16530002: Move Color and FillLayer properties to new StyleBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/DeprecatedStyleBuilder.cpp ('k') | Source/core/scripts/make_style_builder.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 class StyleResolver; 104 class StyleResolver;
105 class TransformationMatrix; 105 class TransformationMatrix;
106 106
107 class ContentData; 107 class ContentData;
108 108
109 typedef Vector<RefPtr<RenderStyle>, 4> PseudoStyleCache; 109 typedef Vector<RefPtr<RenderStyle>, 4> PseudoStyleCache;
110 110
111 class RenderStyle: public RefCounted<RenderStyle> { 111 class RenderStyle: public RefCounted<RenderStyle> {
112 friend class CSSPropertyAnimation; // Used by CSS animations. We can't allow them to animate based off visited colors. 112 friend class CSSPropertyAnimation; // Used by CSS animations. We can't allow them to animate based off visited colors.
113 friend class ApplyStyleCommand; // Editing has to only reveal unvisited info . 113 friend class ApplyStyleCommand; // Editing has to only reveal unvisited info .
114 friend class DeprecatedStyleBuilder; // Sets members directly.
115 friend class EditingStyle; // Editing has to only reveal unvisited info. 114 friend class EditingStyle; // Editing has to only reveal unvisited info.
116 friend class CSSComputedStyleDeclaration; // Ignores visited styles, so need s to be able to see unvisited info. 115 friend class CSSComputedStyleDeclaration; // Ignores visited styles, so need s to be able to see unvisited info.
117 friend class PropertyWrapperMaybeInvalidColor; // Used by CSS animations. We can't allow them to animate based off visited colors. 116 friend class PropertyWrapperMaybeInvalidColor; // Used by CSS animations. We can't allow them to animate based off visited colors.
118 friend class RenderSVGResource; // FIXME: Needs to alter the visited state b y hand. Should clean the SVG code up and move it into RenderStyle perhaps. 117 friend class RenderSVGResource; // FIXME: Needs to alter the visited state b y hand. Should clean the SVG code up and move it into RenderStyle perhaps.
119 friend class RenderTreeAsText; // FIXME: Only needed so the render tree can keep lying and dump the wrong colors. Rebaselining would allow this to be yanke d. 118 friend class RenderTreeAsText; // FIXME: Only needed so the render tree can keep lying and dump the wrong colors. Rebaselining would allow this to be yanke d.
119 friend class StyleBuilderFunctions; // Sets color styles
120 friend class StyleResolver; // Sets members directly. 120 friend class StyleResolver; // Sets members directly.
121 friend class StyleResolverState; // Sets members directly. 121 friend class StyleResolverState; // Sets members directly.
122 protected: 122 protected:
123 123
124 // non-inherited attributes 124 // non-inherited attributes
125 DataRef<StyleBoxData> m_box; 125 DataRef<StyleBoxData> m_box;
126 DataRef<StyleVisualData> visual; 126 DataRef<StyleVisualData> visual;
127 DataRef<StyleBackgroundData> m_background; 127 DataRef<StyleBackgroundData> m_background;
128 DataRef<StyleSurroundData> surround; 128 DataRef<StyleSurroundData> surround;
129 DataRef<StyleRareNonInheritedData> rareNonInheritedData; 129 DataRef<StyleRareNonInheritedData> rareNonInheritedData;
(...skipping 1633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1763 if (compareEqual(rareInheritedData->m_textOrientation, textOrientation)) 1763 if (compareEqual(rareInheritedData->m_textOrientation, textOrientation))
1764 return false; 1764 return false;
1765 1765
1766 rareInheritedData.access()->m_textOrientation = textOrientation; 1766 rareInheritedData.access()->m_textOrientation = textOrientation;
1767 return true; 1767 return true;
1768 } 1768 }
1769 1769
1770 } // namespace WebCore 1770 } // namespace WebCore
1771 1771
1772 #endif // RenderStyle_h 1772 #endif // RenderStyle_h
OLDNEW
« no previous file with comments | « Source/core/css/DeprecatedStyleBuilder.cpp ('k') | Source/core/scripts/make_style_builder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698