Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Issue 16529003: Simplify 'position' adjustment of top layer elements (Closed)

Created:
7 years, 6 months ago by falken
Modified:
7 years, 6 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Visibility:
Public.

Description

Simplify 'position' adjustment of top layer elements Previously, we adjusted 'position' and 'display' for top layer elements. There is already code to adjust the 'display' of positioned elements, using equivalentBlockDisplay. This commit moves top layer element adjustment above that code, so we don't have to set display separately. Also, convert the relevant layout tests from ref-tests to check-layout tests, as they are just testing position. BUG=140205 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151903

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
falken
Morita-san, could you please review?
7 years, 6 months ago (2013-06-06 05:11:50 UTC) #1
Hajime Morrita
lgtm.
7 years, 6 months ago (2013-06-06 05:18:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/16529003/1
7 years, 6 months ago (2013-06-06 05:22:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=11712
7 years, 6 months ago (2013-06-06 06:31:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/16529003/1
7 years, 6 months ago (2013-06-06 07:22:43 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 08:44:40 UTC) #6
Message was sent while issue was closed.
Change committed as 151903

Powered by Google App Engine
This is Rietveld 408576698