Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: media/base/android/sdk_media_codec_bridge.h

Issue 1651673002: Add MediaCodecAudioDecoder implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/sdk_media_codec_bridge.h
diff --git a/media/base/android/sdk_media_codec_bridge.h b/media/base/android/sdk_media_codec_bridge.h
index 19ee9849e7f8d2d60c0c9f59fe2d7852fd498e50..84f12182ec7afdc779aaa6e4aade97fd1d1fed1a 100644
--- a/media/base/android/sdk_media_codec_bridge.h
+++ b/media/base/android/sdk_media_codec_bridge.h
@@ -104,7 +104,15 @@ class MEDIA_EXPORT AudioCodecBridge : public SdkMediaCodecBridge {
// See MediaCodecUtil::IsKnownUnaccelerated().
static bool IsKnownUnaccelerated(const AudioCodec& codec);
- // Start the audio codec bridge.
+ // Start the audio codec bridge. If |play_audio| is true this method creates
+ // Android AudioTrack object for the actual audio playback
+ // (http://developer.android.com/reference/android/media/AudioTrack.html).
+ bool ConfigureAndStart(const AudioDecoderConfig& config,
+ bool play_audio,
+ jobject media_crypto);
+
+ // An overloaded variant used by AudioDecoderJob and AudioMediaCodecDecoder.
+ // We might want to remove this method when these classes go away.
qinmin 2016/02/16 19:25:09 can we remove this method? We can pack in all the
Tima Vaisburd 2016/02/16 21:23:26 One way to do this would be to make a method that
bool ConfigureAndStart(const AudioCodec& codec,
int sample_rate,
int channel_count,
« no previous file with comments | « no previous file | media/base/android/sdk_media_codec_bridge.cc » ('j') | media/filters/android/media_codec_audio_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698