Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16511009: Use a direct include of strings headers in cloud_print/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use a direct include of strings headers in cloud_print/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M cloud_print/common/win/cloud_print_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/common/win/install_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/service_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/service_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/local_security_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/local_security_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/setup_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_dll.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16511009/1
7 years, 6 months ago (2013-06-10 20:23:59 UTC) #1
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=48306
7 years, 6 months ago (2013-06-10 23:23:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16511009/1
7 years, 6 months ago (2013-06-10 23:26:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=136697
7 years, 6 months ago (2013-06-11 03:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16511009/1
7 years, 6 months ago (2013-06-11 03:35:33 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 06:22:29 UTC) #6
Message was sent while issue was closed. 
Change committed as 205432

Powered by Google App Engine
This is Rietveld 408576698