Cleanup constants for layerTreeAsText.

Cleanup constants for layerTreeAsText.
    
- Removed LAYER_TREE_INCLUDES_TILE_CACHES and LAYER_TREE_INCLUDES_VISIBLE_RECTS
  which are not used in blink;
- Combined the enums and constants to one set of values;
- BTW, changed the naming of composited-scrolling constants in Internals.idl
  to keep consistence.

BUG=none
R=enne
TBR=jamesr

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152294

[Xianzhu, 2013-06-11 17:45:46]

This CL is separated from https://codereview.chromium.org/155888012.

[enne (OOO), 2013-06-11 18:30:58]

I don't know what Blink's official coding standard is for idl files.  However,
it looks to me like all but 3 are in ALL_CAPS.  For the sake of consistency, I
don't think these should be changed.

$ git grep "^\s*const" -- "*.idl" | wc -l
846

$ git grep "^\s*const" -- "*.idl" | grep "[A-Z][A-Z]" | wc -l
843

[Xianzhu, 2013-06-11 18:54:35]

On 2013/06/11 18:30:58, enne wrote:
> I don't know what Blink's official coding standard is for idl files.  However,
> it looks to me like all but 3 are in ALL_CAPS.  For the sake of consistency, I
> don't think these should be changed.
> 
> $ git grep "^\s*const" -- "*.idl" | wc -l
> 846
> 
> $ git grep "^\s*const" -- "*.idl" | grep "[A-Z][A-Z]" | wc -l
> 843

I changed the names after presubmit reported errors against the ALL_CAPS names.
Will ask the author of presubmit script.

[Xianzhu, 2013-06-11 19:04:43]

On 2013/06/11 18:54:35, Xianzhu wrote:
> On 2013/06/11 18:30:58, enne wrote:
> > I don't know what Blink's official coding standard is for idl files. 
However,
> > it looks to me like all but 3 are in ALL_CAPS.  For the sake of consistency,
I
> > don't think these should be changed.
> > 
> > $ git grep "^\s*const" -- "*.idl" | wc -l
> > 846
> > 
> > $ git grep "^\s*const" -- "*.idl" | grep "[A-Z][A-Z]" | wc -l
> > 843
> 
> I changed the names after presubmit reported errors against the ALL_CAPS
names.
> Will ask the author of presubmit script.

I see where the problem comes: actually presumbit reported errors against the
ALL_CAPS
enum names defined in Internals.h, not the corresponding constants in idl. In
Settings.idl
there are 6 consts: 3 of them have been changed to conform to enum naming in
https://chromiumcodereview.appspot.com/14858004, and this CL is to change the
remaining 3. I think we'd better following the changed ones to keep consistency
in this file.

Other idls need to follow standards e.g. W3C for the names.

[enne (OOO), 2013-06-11 19:17:27]

On 2013/06/11 19:04:43, Xianzhu wrote:

> I see where the problem comes: actually presumbit reported errors against the
> ALL_CAPS
> enum names defined in Internals.h, not the corresponding constants in idl. In
> Settings.idl
> there are 6 consts: 3 of them have been changed to conform to enum naming in
> https://chromiumcodereview.appspot.com/14858004, and this CL is to change the
> remaining 3. I think we'd better following the changed ones to keep
consistency
> in this file.
> 
> Other idls need to follow standards e.g. W3C for the names.

Sorry, but I disagree.  It seems to me like those 6 should be more like the
other 840.

[Xianzhu, 2013-06-11 19:19:51]

On 2013/06/11 19:17:27, enne wrote:
> On 2013/06/11 19:04:43, Xianzhu wrote:
> 
> > I see where the problem comes: actually presumbit reported errors against
the
> > ALL_CAPS
> > enum names defined in Internals.h, not the corresponding constants in idl.
In
> > Settings.idl
> > there are 6 consts: 3 of them have been changed to conform to enum naming in
> > https://chromiumcodereview.appspot.com/14858004, and this CL is to change
the
> > remaining 3. I think we'd better following the changed ones to keep
> consistency
> > in this file.
> > 
> > Other idls need to follow standards e.g. W3C for the names.
> 
> Sorry, but I disagree.  It seems to me like those 6 should be more like the
> other 840.

Then would you suggest we use different names for the same constants in
Internals.h/cpp and Internals.idl?

[enne (OOO), 2013-06-11 19:22:45]

On 2013/06/11 19:19:51, Xianzhu wrote:

> Then would you suggest we use different names for the same constants in
> Internals.h/cpp and Internals.idl?

Sounds reasonable to me.  Other places in code do this, e.g. CSSFilterValue.

[Xianzhu, 2013-06-11 22:25:02]

PTAL.

https://codereview.chromium.org/16509007/diff/5001/Source/core/testing/Intern...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/16509007/diff/5001/Source/core/testing/Intern...
Source/core/testing/Internals.idl:28: DoNotCheckConstants
This is required otherwise the idl compiler will generate code checking for each
constant if there is a symbol with the same name and value defined in C++ code.

This seems not an issue because actually we don't need to define the values in
Internals.h.

[enne (OOO), 2013-06-11 23:56:59]

lgtm

[commit-bot: I haz the power, 2013-06-12 00:05:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/16509007/5001

[commit-bot: I haz the power, 2013-06-12 02:14:44]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-06-12 18:01:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/16509007/5001

[commit-bot: I haz the power, 2013-06-12 19:50:13]

Change committed as 152294