Fix mouse wheel events in pointer lock on aura.

Fix mouse wheel events in pointer lock on aura.

Wheel events were incorrectly being constructed as
mouse events, and not being handled correctly.

BUG=242181
TEST=Use mouse wheel on http://scheib.github.com/HTMLMisc/PointerLockAndFullscreen.html on Chrome OS and windows aura builds.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204958

[ananta, 2013-06-05 23:16:13]

https://codereview.chromium.org/16505003/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/16505003/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_aura.cc:2334: if
(event->type() == ui::ET_MOUSEWHEEL) {
We should be handling this similarly for mouse wheel events received when the
mouse is not locked?

[scheib, 2013-06-06 02:42:37]

Thanks.

https://codereview.chromium.org/16505003/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/16505003/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_aura.cc:2334: if
(event->type() == ui::ET_MOUSEWHEEL) {
On 2013/06/05 23:16:14, ananta wrote:
> We should be handling this similarly for mouse wheel events received when the
> mouse is not locked?

True. That code already exists below, outside of the if(mouse_locked_) block. It
is more complicated as it deals with not having focus on Windows. While in mouse
like we will always have focus (loss of focus drops mouse lock).

https://codereview.chromium.org/16505003/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_aura.cc:2384: if
(event->type() == ui::ET_MOUSEWHEEL) {
Here.

[ananta, 2013-06-06 21:07:22]

lgtm

[commit-bot: I haz the power, 2013-06-06 22:18:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/16505003/1

[commit-bot: I haz the power, 2013-06-06 23:37:31]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[scheib, 2013-06-07 04:21:34]

ben, owners please.

[Ben Goodger (Google), 2013-06-07 16:17:39]

lgtm

[commit-bot: I haz the power, 2013-06-07 18:19:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/16505003/1

[commit-bot: I haz the power, 2013-06-07 22:20:19]

Change committed as 204958