Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 16501003: text-transform: capitalize shouldn't upconvert (Closed)

Created:
7 years, 6 months ago by abarth-chromium
Modified:
7 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

text-transform: capitalize shouldn't upconvert In looking at STRING_STATS for Mobile New York Times, I noticed that text-transform: capitalize is bloating memory by upconverting strings. It's a small amount of memory, but there's no reason to upconvert the strings. After this CL, all the strings used by Mobile New York Times are fully optimized (or at least they will be after https://codereview.chromium.org/16158008/ lands). R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/rendering/RenderText.cpp View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
7 years, 6 months ago (2013-06-06 19:39:26 UTC) #1
eseidel
lgtm
7 years, 6 months ago (2013-06-06 20:05:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/16501003/1
7 years, 6 months ago (2013-06-06 20:05:14 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 23:18:49 UTC) #4
Message was sent while issue was closed.
Change committed as 151976

Powered by Google App Engine
This is Rietveld 408576698