Chromium Code Reviews| Index: media/mojo/services/BUILD.gn |
| diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn |
| index d7581c005bc9763a5d59023dd811033e846b97d9..344493a05c41ca6fd7c47130004bb7deca97a6b0 100644 |
| --- a/media/mojo/services/BUILD.gn |
| +++ b/media/mojo/services/BUILD.gn |
| @@ -80,26 +80,6 @@ source_set("proxy") { |
| ] |
| } |
| -source_set("media_client") { |
| - sources = [ |
| - "mojo_media_client.cc", |
| - "mojo_media_client.h", |
| - ] |
| - if (is_android) { |
| - sources += [ "android_mojo_media_client.cc" ] |
| - } else { |
| - sources += [ "default_mojo_media_client.cc" ] |
| - } |
| - |
| - public_configs = [ ":enable_mojo_media_config" ] |
| - |
| - deps = [ |
| - "//base", |
| - "//media", |
| - "//media:shared_memory_support", |
| - ] |
| -} |
| - |
| source_set("cdm_service") { |
| deps = [ |
| ":converters", |
| @@ -131,6 +111,7 @@ source_set("cdm_service") { |
| ] |
| } |
| + public_configs = [ ":enable_mojo_media_config" ] |
|
xhwang
2016/02/02 20:25:16
Can you add a comment that we need this because ta
alokp
2016/02/02 20:37:00
Done with a TODO assigned to you :)
xhwang
2016/02/02 20:46:49
Thanks!
|
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] |
| } |
| @@ -144,6 +125,8 @@ source_set("renderer_service") { |
| "mojo_renderer_service.h", |
| ] |
| + public_configs = [ ":enable_mojo_media_config" ] |
|
xhwang
2016/02/02 20:25:16
Is this needed by any code today?
alokp
2016/02/02 20:37:00
No. I did it for symmetry but I should remove it n
|
| + |
| deps = [ |
| ":converters", |
| "//base", |
| @@ -158,6 +141,8 @@ source_set("application") { |
| sources = [ |
| "mojo_media_application.cc", |
| "mojo_media_application.h", |
| + "mojo_media_client.cc", |
| + "mojo_media_client.h", |
| "service_factory_impl.cc", |
| "service_factory_impl.h", |
| ] |
| @@ -166,14 +151,29 @@ source_set("application") { |
| deps = [ |
| ":cdm_service", |
| - ":media_client", |
| ":renderer_service", |
| - "//base", |
| - "//mojo/public/c/system:for_component", |
| "//mojo/shell/public/cpp", |
| ] |
| } |
| +source_set("default_application") { |
| + if (is_android) { |
| + sources = [ |
| + "android_mojo_media_client.cc", |
| + ] |
| + } else { |
| + sources = [ |
| + "default_mojo_media_client.cc", |
| + ] |
| + } |
| + |
| + public_configs = [ ":enable_mojo_media_config" ] |
| + |
| + deps = [ |
| + ":application", |
| + ] |
| +} |
| + |
| test("media_mojo_unittests") { |
| sources = [ |
| "media_type_converters_unittest.cc", |
| @@ -200,7 +200,8 @@ mojo_native_application("media") { |
| ] |
| deps = [ |
| - ":application", |
| + ":default_application", |
| + "//mojo/logging", |
| "//mojo/public/c/system:for_shared_library", |
| ] |
| } |