[Chromecast] Hook up mojo media pipeline.

chromecast/media/mojo/cast_media_application.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/scoped_ptr.h"
+#include "chromecast/media/mojo/cast_media_client.h"
+#include "media/mojo/interfaces/service_factory.mojom.h"
+#include "mojo/shell/public/cpp/application_delegate.h"
+#include "mojo/shell/public/cpp/interface_factory_impl.h"
+
+namespace chromecast {
+namespace media {
+
+class CastMediaApplication

[xhwang, 2016/01/29 05:44:13]

Is there any reason Cast can't just use the MojoMediaApplication?

[alokp, 2016/01/29 06:08:36]

It could. We either need to figure out how to create CastMediaClient via
MojoMediaClient::Create or perhaps create another target that contains
MojoMediaApplication without the concrete implementation of MojoMediaClient. Do
you have any suggestions?

Although there is not much happening inside MojoMediaApplication. Most of the
logic is implemented in ServiceFactory and various services that we are
re-using.

[xhwang, 2016/01/29 07:00:44]

+jrummell

We will actually need something similar on desktop where we need a "content"
based MojoMediaClient. So there will be at least four MojoMediaClient
implementations:
1. The current media::DefaultMojoMediaClient will be renamed to
media::TestMojoMediaClient, since it's for test only.
2. media::AndroidMojoMediaClient
3. content::MojoMediaClient for desktop
4. chromecast::media::CastMojoMediaClient

We can probably exclude the MojoMediaClient implementation from the
"application" target. The target that is dependent on "application" should also
depend on a source_set that includes the MojoMediaClient implementation. For
example, in chromecast/media/mojo/BUILD.gn:

     source_set("mojo") {
 11   sources = [
 14     "cast_media_client.cc",
 15     "cast_media_client.h",
 16   ]
 17   deps = [
 18     "//base",
 19     "//media/mojo/interfaces:interfaces_cpp_sources",
 20     "//media/mojo/services:application",
 21     "//mojo/shell/public/cpp",
 22   ]
 23 
 24   public_configs = [ "//media/mojo/services:enable_mojo_media_config" ]
 25 }

[alokp, 2016/01/29 18:29:25]

I considered doing that originally but thought it might not be ideal to have to
depend on multiple targets. I will upload a patch shortly with your proposal and
see if you like it any better.

+    : public mojo::ApplicationDelegate,
+      public mojo::InterfaceFactory<::media::interfaces::ServiceFactory> {
+ public:
+  CastMediaApplication();
+  ~CastMediaApplication() override;
+
+  static scoped_ptr<mojo::ApplicationDelegate> CreateApp();
+
+  // mojo::ApplicationDelegate implementation.
+  void Initialize(mojo::ApplicationImpl* app_impl) override;
+  bool ConfigureIncomingConnection(
+      mojo::ApplicationConnection* connection) override;
+
+  // mojo::InterfaceFactory<interfaces::ServiceFactory> implementation.
+  void Create(mojo::ApplicationConnection* connection,
+              mojo::InterfaceRequest<::media::interfaces::ServiceFactory>
+                  request) final;
+
+ private:
+  mojo::ApplicationImpl* app_impl_;
+  CastMediaClient media_client_;
+  scoped_refptr<::media::MediaLog> media_log_;
+};
+
+}  // namespace media
+}  // namespace chromecast