Issue 16480002: Fix some potential after free errors on TestCompletionCallback

Issue 16480002: Fix some potential after free errors on TestCompletionCallback (Closed)

Created:
7 years, 6 months ago by gavinp

Modified:
7 years, 5 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some potential after free errors on TestCompletionCallback It's illegal to destroy a TestCompletionCallback while a callback is pending. Stop this badness by removing test assertions that could cause this. R=rvargas BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208749

Patch Set 1 #

Patch Set 2 : another one #

Total comments: 2

Patch Set 3 : epic rebase #

Patch Set 4 : remediate to review #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	net/cert/multi_threaded_cert_verifier_unittest.cc	View	1 2	9 chunks	+11 lines, -11 lines	0 comments	Download
	M	net/http/http_cache_unittest.cc	View	1 2 3	1 chunk	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

gavinp

Ricardo, Here's a few of these. Might as well get rid of them while we ...

7 years, 6 months ago (2013-06-05 20:48:50 UTC) #1

gavinp

There was one more of these to prevent an infinite hang in http_cache_test. Can you ...

7 years, 6 months ago (2013-06-06 13:34:46 UTC) #3

rvargas (doing something else)

https://codereview.chromium.org/16480002/diff/17001/net/http/http_cache_unittest.cc File net/http/http_cache_unittest.cc (right): https://codereview.chromium.org/16480002/diff/17001/net/http/http_cache_unittest.cc#newcode5935 net/http/http_cache_unittest.cc:5935: ASSERT_EQ(net::ERR_IO_PENDING, Why does this matter? (where does it hangs?). ...

7 years, 6 months ago (2013-06-06 18:55:48 UTC) #4

gavinp

Thanks for the feedback. I removed one of the files as I can't find it ...

7 years, 5 months ago (2013-06-26 00:07:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/16480002/42001

7 years, 5 months ago (2013-06-26 16:48:40 UTC) #7

Message was sent while issue was closed.

Change committed as 208749

Expand Messages | Collapse Messages