Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2373)

Unified Diff: chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc

Issue 1647723002: [win/cros/lin] Add back the spellcheck menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix signed/unsigned warning. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
diff --git a/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc b/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..73301f9b46ad1ab5c0febc83c46e491f9f8b91d6
--- /dev/null
+++ b/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
@@ -0,0 +1,198 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/renderer_context_menu/spelling_options_submenu_observer.h"
+
+#include <algorithm>
+
+#include "base/logging.h"
+#include "base/prefs/pref_member.h"
+#include "base/prefs/pref_service.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
+#include "chrome/browser/spellchecker/spellcheck_service.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/spellcheck_common.h"
+#include "chrome/grit/generated_resources.h"
+#include "content/public/browser/render_view_host.h"
lazyboy 2016/02/01 22:58:12 Do you really need these? It seems like we have to
please use gerrit instead 2016/02/02 00:28:51 Done.
+#include "content/public/browser/render_widget_host_view.h"
+#include "extensions/browser/view_type_utils.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/models/simple_menu_model.h"
+
+using content::BrowserThread;
+
+SpellingOptionsSubMenuObserver::SpellingOptionsSubMenuObserver(
+ RenderViewContextMenuProxy* proxy,
+ ui::SimpleMenuModel::Delegate* delegate,
+ int group_id)
+ : proxy_(proxy),
+ submenu_model_(delegate),
+ language_group_id_(group_id),
+ num_selected_languages_(0) {
+ DCHECK(proxy_);
+}
+
+SpellingOptionsSubMenuObserver::~SpellingOptionsSubMenuObserver() {}
+
+void SpellingOptionsSubMenuObserver::InitMenu(
+ const content::ContextMenuParams& params) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+ // Add available spell-checker languages to the sub menu.
+ content::BrowserContext* browser_context = proxy_->GetBrowserContext();
+ DCHECK(browser_context);
+ num_selected_languages_ =
+ SpellcheckService::GetSpellCheckLanguages(browser_context, &languages_);
+ DCHECK(languages_.size() <
+ IDC_SPELLCHECK_LANGUAGES_LAST - IDC_SPELLCHECK_LANGUAGES_FIRST);
+ const std::string app_locale = g_browser_process->GetApplicationLocale();
+
+ if (languages_.size() > 1) {
+ submenu_model_.AddRadioItemWithStringId(
+ IDC_SPELLCHECK_MULTI_LINGUAL,
+ IDS_CONTENT_CONTEXT_SPELLCHECK_MULTI_LINGUAL, language_group_id_);
+ }
+
+ const size_t kMaxLanguages = static_cast<size_t>(
+ IDC_SPELLCHECK_LANGUAGES_FIRST - IDC_SPELLCHECK_LANGUAGES_LAST);
+ for (size_t i = 0; i < languages_.size() && i < kMaxLanguages; ++i) {
+ submenu_model_.AddRadioItem(
+ IDC_SPELLCHECK_LANGUAGES_FIRST + i,
+ l10n_util::GetDisplayNameForLocale(languages_[i], app_locale, true),
+ language_group_id_);
+ }
+
+ // Add an item that opens the 'fonts and languages options' page.
+ submenu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
+ submenu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS,
+ IDS_CONTENT_CONTEXT_LANGUAGE_SETTINGS);
+
+ if (num_selected_languages_ > 0) {
+ // Add a 'Check spelling while typing' item in the sub menu.
+ submenu_model_.AddCheckItem(
+ IDC_CHECK_SPELLING_WHILE_TYPING,
+ l10n_util::GetStringUTF16(
+ IDS_CONTENT_CONTEXT_CHECK_SPELLING_WHILE_TYPING));
+ }
+
+ // Add a check item "Ask Google for spelling suggestions" item. (This class
+ // does not handle this item because the SpellingMenuObserver class handles it
+ // on behalf of this class.)
+ submenu_model_.AddCheckItem(
+ IDC_CONTENT_CONTEXT_SPELLING_TOGGLE,
+ l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_SPELLING_ASK_GOOGLE));
+
+ proxy_->AddSubMenu(
+ IDC_SPELLCHECK_MENU,
+ l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_SPELLCHECK_MENU),
+ &submenu_model_);
+}
+
+bool SpellingOptionsSubMenuObserver::IsCommandIdSupported(int command_id) {
+ // Allow Spell Check language items on sub menu for text area context menu.
+ if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+ command_id < IDC_SPELLCHECK_LANGUAGES_LAST) {
+ return true;
+ }
+
+ switch (command_id) {
+ case IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS:
+ // Return false so RenderViewContextMenu can handle this item because it
+ // is hard for this class to handle it.
+ return false;
+
+ case IDC_CHECK_SPELLING_WHILE_TYPING:
+ case IDC_SPELLCHECK_MENU:
+ case IDC_SPELLCHECK_MULTI_LINGUAL:
+ return true;
+ }
+
+ return false;
+}
+
+bool SpellingOptionsSubMenuObserver::IsCommandIdChecked(int command_id) {
+ DCHECK(IsCommandIdSupported(command_id));
+
+ if (command_id == IDC_SPELLCHECK_MULTI_LINGUAL)
+ return num_selected_languages_ == languages_.size();
+
+ if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+ command_id < IDC_SPELLCHECK_LANGUAGES_LAST) {
+ if (languages_.size() == 1 && num_selected_languages_ == 1)
+ return true;
+
+ if (languages_.size() == num_selected_languages_)
+ return false;
+
+ size_t language_index =
+ static_cast<size_t>(command_id - IDC_SPELLCHECK_LANGUAGES_FIRST);
+ // The first |num_selected_languages_| are used for spellchecking.
+ return num_selected_languages_ > language_index;
+ }
+
+ // Check box for 'Check Spelling while typing'.
+ if (command_id == IDC_CHECK_SPELLING_WHILE_TYPING) {
+ Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
+ return profile->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck);
+ }
+
+ return false;
+}
+
+bool SpellingOptionsSubMenuObserver::IsCommandIdEnabled(int command_id) {
+ DCHECK(IsCommandIdSupported(command_id));
+
+ Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
+ DCHECK(profile);
+ const PrefService* pref = profile->GetPrefs();
+ if ((command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+ command_id < IDC_SPELLCHECK_LANGUAGES_LAST) ||
+ command_id == IDC_SPELLCHECK_MULTI_LINGUAL) {
+ return pref->GetBoolean(prefs::kEnableContinuousSpellcheck);
+ }
+
+ switch (command_id) {
+ case IDC_CHECK_SPELLING_WHILE_TYPING:
+ case IDC_SPELLCHECK_MENU:
+ return true;
+ }
+
+ return false;
+}
+
+void SpellingOptionsSubMenuObserver::ExecuteCommand(int command_id) {
+ DCHECK(IsCommandIdSupported(command_id));
+
+ // Check to see if one of the spell check language ids have been clicked.
+ Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
+ DCHECK(profile);
+
+ if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+ static_cast<size_t>(command_id) <
+ IDC_SPELLCHECK_LANGUAGES_FIRST + languages_.size()) {
+ size_t language_index = command_id - IDC_SPELLCHECK_LANGUAGES_FIRST;
+ StringListPrefMember dictionaries_pref;
+ dictionaries_pref.Init(prefs::kSpellCheckDictionaries, profile->GetPrefs());
+ dictionaries_pref.SetValue({languages_[language_index]});
+ return;
+ }
+
+ switch (command_id) {
+ case IDC_CHECK_SPELLING_WHILE_TYPING:
+ profile->GetPrefs()->SetBoolean(
+ prefs::kEnableContinuousSpellcheck,
+ !profile->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck));
+ break;
+
+ case IDC_SPELLCHECK_MULTI_LINGUAL:
+ StringListPrefMember dictionaries_pref;
+ dictionaries_pref.Init(prefs::kSpellCheckDictionaries,
+ profile->GetPrefs());
+ dictionaries_pref.SetValue(languages_);
+ break;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698