Add chrome.runtime.getPackageDirectoryEntry.

Add chrome.runtime.getPackageDirectoryEntry.

This allows an app or extension to get a read-only directory entry for
its package directory.

BUG=177208
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206315

[Matt Giuca, 2013-06-07 08:11:53]

Removing myself, since I will be away for the next week.

[benwells, 2013-06-11 03:14:51]

Nice, very close.

https://codereview.chromium.org/16470003/diff/34002/chrome/browser/extensions...
File chrome/browser/extensions/api/runtime/runtime_api.cc (right):

https://codereview.chromium.org/16470003/diff/34002/chrome/browser/extensions...
chrome/browser/extensions/api/runtime/runtime_api.cc:60: const char
kPackageDirectoryPath[] = "crxfs";
If I'm reading this correctly, this could be anything and it would be virtually
transparent to the user. If that is so, I'd rather either:
- use the version number of the app so this matches the actual folder on the
disk
- use the extension id.

But I'm not really that fussed. Either way please add a comment that this is an
internal thing that won't be very visible to the app.

https://codereview.chromium.org/16470003/diff/34002/chrome/test/data/extensio...
File
chrome/test/data/extensions/api_test/runtime/get_package_directory/app/test.js
(right):

https://codereview.chromium.org/16470003/diff/34002/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/runtime/get_package_directory/app/test.js:17:
var directoryContents = [];
This test is quite strange. Why do you call readEntries twice on the same
directory reader?

Also it would be good to test that files in subfolders of the crx folder can be
seen.

[Sam McNally, 2013-06-11 06:00:29]

https://codereview.chromium.org/16470003/diff/34002/chrome/browser/extensions...
File chrome/browser/extensions/api/runtime/runtime_api.cc (right):

https://codereview.chromium.org/16470003/diff/34002/chrome/browser/extensions...
chrome/browser/extensions/api/runtime/runtime_api.cc:60: const char
kPackageDirectoryPath[] = "crxfs";
On 2013/06/11 03:14:51, benwells wrote:
> If I'm reading this correctly, this could be anything and it would be
virtually
> transparent to the user. If that is so, I'd rather either:
> - use the version number of the app so this matches the actual folder on the
> disk
> - use the extension id.
> 
> But I'm not really that fussed. Either way please add a comment that this is
an
> internal thing that won't be very visible to the app.

Done.

https://codereview.chromium.org/16470003/diff/34002/chrome/test/data/extensio...
File
chrome/test/data/extensions/api_test/runtime/get_package_directory/app/test.js
(right):

https://codereview.chromium.org/16470003/diff/34002/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/runtime/get_package_directory/app/test.js:17:
var directoryContents = [];
On 2013/06/11 03:14:51, benwells wrote:
> This test is quite strange. Why do you call readEntries twice on the same
> directory reader?
readEntries might not return all entries in a single call and should be called
until it returns an empty array.
> 
> Also it would be good to test that files in subfolders of the crx folder can
be
> seen.

Done.

[benwells, 2013-06-11 06:14:13]

lgtm

[commit-bot: I haz the power, 2013-06-11 06:15:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/46002

[commit-bot: I haz the power, 2013-06-11 08:06:36]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-12 02:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/21002

[commit-bot: I haz the power, 2013-06-12 05:25:52]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-13 00:03:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/111001

[commit-bot: I haz the power, 2013-06-13 02:49:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/111001

[commit-bot: I haz the power, 2013-06-13 06:50:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-13 08:49:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/111001

[commit-bot: I haz the power, 2013-06-13 08:54:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-13 23:19:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/111001

[commit-bot: I haz the power, 2013-06-14 02:17:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/16470003/156002

[commit-bot: I haz the power, 2013-06-14 06:05:15]

Change committed as 206315