Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 16465002: Remove virtual from functions that are never overridden. (Closed)

Created:
7 years, 6 months ago by dmazzoni
Modified:
7 years, 6 months ago
Reviewers:
aboxhall
CC:
blink-reviews, dmazzoni, eae+blinkwatch, aboxhall
Visibility:
Public.

Description

Remove virtual from functions that are never overridden. I checked these by writing a quick Python script; none of these functions are found in any other header files in this directory. I was surprised how much this cuts down on code size. I'm going to aggressively get rid of virtual functions when they're not useful. The main reason this helps so much is because there are so many subclasses of AccessibilityObject. BUG=247082 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M Source/core/accessibility/AccessibilityNodeObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityObject.h View 14 chunks +57 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
7 years, 6 months ago (2013-06-05 18:56:57 UTC) #1
aboxhall
lgtm
7 years, 6 months ago (2013-06-05 18:58:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/16465002/1
7 years, 6 months ago (2013-06-05 21:54:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1185
7 years, 6 months ago (2013-06-05 22:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/16465002/1
7 years, 6 months ago (2013-06-05 22:45:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/16465002/1
7 years, 6 months ago (2013-06-05 23:32:14 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 02:14:05 UTC) #7
Message was sent while issue was closed.
Change committed as 151879

Powered by Google App Engine
This is Rietveld 408576698