Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1646443002: Remove CompressibleStringImpl::s_isPageBackground (Closed)

Created:
4 years, 11 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
haraken, Ilya Sherman
CC:
chromium-reviews, blink-reviews, kinuko+watch, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CompressibleStringImpl::s_isPageBackground This CL removes a static variable s_isPageBackground which is used to tell the current tab is in background or foreground. It is because it's almost impossible to tell this. For example, one renderer process of a new tab page is used for multiple tabs. Another example is that reloading a page will re-use the process with a new Page object and updating a static variable along with reloading will be complex. After this CL, we won't be able to get the number of decompression only in a background tab. With the new UMA, we can't give a go-sign for CompressibleString but at least we can give a no-go-sign. BUG=581266 TEST=n/a Committed: https://crrev.com/01b6c4d4696d85645e0db3fc602b8da9203ce748 Cr-Commit-Position: refs/heads/master@{#372012}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/CompressibleString.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/CompressibleString.cpp View 4 chunks +10 lines, -16 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
hajimehoshi
PTAL isherman, I updated histgrams.xml the way in which it might break the backward compatibility. ...
4 years, 11 months ago (2016-01-27 12:06:11 UTC) #2
haraken
WebKit change LGTM
4 years, 11 months ago (2016-01-27 12:09:32 UTC) #3
Ilya Sherman
histograms.xml lgtm with a warning: https://codereview.chromium.org/1646443002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1646443002/diff/1/tools/metrics/histograms/histograms.xml#newcode59163 tools/metrics/histograms/histograms.xml:59163: + <int value="1" label="Decompressed ...
4 years, 10 months ago (2016-01-28 02:08:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646443002/1
4 years, 10 months ago (2016-01-28 02:41:38 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2016-01-28 04:04:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646443002/1
4 years, 10 months ago (2016-01-28 04:21:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 04:27:50 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 04:28:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01b6c4d4696d85645e0db3fc602b8da9203ce748
Cr-Commit-Position: refs/heads/master@{#372012}

Powered by Google App Engine
This is Rietveld 408576698