chrome/common/extensions/manifest_handlers/externally_connectable.h - Issue 16464004: Turn disallowed URL patterns such as <all_urls> for externally_connectable into

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/externally_connectable.h

Issue 16464004: Turn disallowed URL patterns such as <all_urls> for externally_connectable into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test that warnings also imply failure Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest_handlers/externally_connectable.h

diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable.h b/chrome/common/extensions/manifest_handlers/externally_connectable.h

index 595cef00b9d0c6b282173c2bfae0dd63c76bcbfb..041c7d284914d77080d6592cc2afae82ab47d31f 100644

--- a/chrome/common/extensions/manifest_handlers/externally_connectable.h

+++ b/chrome/common/extensions/manifest_handlers/externally_connectable.h

@@ -11,6 +11,7 @@

#include "base/memory/scoped_ptr.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/manifest_handler.h"

+#include "extensions/common/install_warning.h"

#include "extensions/common/url_pattern_set.h"

class GURL;

@@ -55,6 +56,7 @@ struct ExternallyConnectableInfo : public Extension::ManifestData {

// the manifest. Sets |error| and returns an empty scoped_ptr on failure.

static scoped_ptr<ExternallyConnectableInfo> FromValue(

const base::Value& value,

+ std::vector<InstallWarning>* install_warnings,

string16* error);

virtual ~ExternallyConnectableInfo();

« no previous file with comments | « no previous file | chrome/common/extensions/manifest_handlers/externally_connectable.cc » ('j') | no next file with comments »