Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 16451004: Remove the duplicated clear of ViewsDelegate::views_delegate in ~ShellViewsDelegateAura(). (Closed)

Created:
7 years, 6 months ago by dshwang
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the duplicated clear of ViewsDelegate::views_delegate in ~ShellViewsDelegateAura(). ~TestViewsDelegate() aleady clears ViewsDelegate::views_delegate, so ~ShellViewsDelegateAura() does not need to clear. ShellViewsDelegateAura extends DesktopTestViewsDelegate that extends TestViewsDelegate. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/shell_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dshwang
7 years, 6 months ago (2013-06-05 12:19:47 UTC) #1
jochen (gone - plz use gerrit)
lgtm can you please either file a bug (or probably better since the change is ...
7 years, 6 months ago (2013-06-05 12:25:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/16451004/1
7 years, 6 months ago (2013-06-05 12:58:43 UTC) #3
dshwang
On 2013/06/05 12:25:36, jochen wrote: > lgtm > > can you please either file a ...
7 years, 6 months ago (2013-06-05 12:59:27 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-05 13:10:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/16451004/1
7 years, 6 months ago (2013-06-05 13:21:34 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 19:42:36 UTC) #7
Message was sent while issue was closed.
Change committed as 204318

Powered by Google App Engine
This is Rietveld 408576698