Issue 16440006: Annotate LeakyLazyInstance as a leak. Remove HeapChecker suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16440006: Annotate LeakyLazyInstance as a leak. Remove HeapChecker suppressions. (Closed)

Created:
7 years, 6 months ago by earthdok_at_google

Modified:
7 years, 6 months ago

Reviewers:
darin (slow to review), jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Annotate LeakyLazyInstance as a leak. Remove HeapChecker suppressions. The two suppressions removed by this CL have not fired for a long time, for some unknown reason. It's still a good idea to annotate all intentional leaks though. BUG=83345 R=jar@chromium.org,darin@chromium.org CC=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204953

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
	M	base/lazy_instance.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	tools/heapcheck/suppressions.txt	View		2 chunks	+0 lines, -16 lines	0 comments	Download

Total messages: 5 (0 generated)

earthdok_at_google

Note that HeapChecker will report a fatal error if the annotated pointer is deleted. By ...

7 years, 6 months ago (2013-06-07 14:42:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@google.com/16440006/1

7 years, 6 months ago (2013-06-07 19:33:26 UTC) #4

Message was sent while issue was closed.

Change committed as 204953