Moved StyleElement::insertedIntoDocument into didNotifySubtreeInsertions.

Moved StyleElement::insertedIntoDocument into didNotifySubtreeInsertions.

We should avoid style-recalc during subtree insertions.

If invoke style-recalc, we might invoke createRenderer for elements that have not been inserted into document yet.
(i.e. the elements' inDocument flags are false).
The recalc also clears needsStyleRecalc flag. This blocks correct style-recalc.

TESTS=fast/dom/shadow/remove-and-insert-style.html
BUG=246300
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151825

[Hajime Morrita, 2013-06-05 07:21:06]

https://codereview.chromium.org/16425002/diff/1/LayoutTests/fast/dom/shadow/r...
File LayoutTests/fast/dom/shadow/remove-and-insert-style.html (right):

https://codereview.chromium.org/16425002/diff/1/LayoutTests/fast/dom/shadow/r...
LayoutTests/fast/dom/shadow/remove-and-insert-style.html:7:
testRunner.waitUntilDone();
You can just set window.jsTestIsAsync = true. No testRunner check is needed.

https://codereview.chromium.org/16425002/diff/1/LayoutTests/fast/dom/shadow/r...
LayoutTests/fast/dom/shadow/remove-and-insert-style.html:63:
testRunner.notifyDone();
Call fnishJSTest().

https://codereview.chromium.org/16425002/diff/1/Source/core/html/HTMLStyleEle...
File Source/core/html/HTMLStyleElement.cpp (right):

https://codereview.chromium.org/16425002/diff/1/Source/core/html/HTMLStyleEle...
Source/core/html/HTMLStyleElement.cpp:208:
StyleElement::insertedIntoDocument(document(), this);
This should no longer be insertedIntoDocument().

[tasak, 2013-06-05 08:30:52]

Thank you for reviewing.

https://codereview.chromium.org/16425002/diff/1/LayoutTests/fast/dom/shadow/r...
File LayoutTests/fast/dom/shadow/remove-and-insert-style.html (right):

https://codereview.chromium.org/16425002/diff/1/LayoutTests/fast/dom/shadow/r...
LayoutTests/fast/dom/shadow/remove-and-insert-style.html:7:
testRunner.waitUntilDone();
On 2013/06/05 07:21:06, morrita1 wrote:
> You can just set window.jsTestIsAsync = true. No testRunner check is needed.

Done.

https://codereview.chromium.org/16425002/diff/1/LayoutTests/fast/dom/shadow/r...
LayoutTests/fast/dom/shadow/remove-and-insert-style.html:63:
testRunner.notifyDone();
On 2013/06/05 07:21:06, morrita1 wrote:
> Call fnishJSTest().

Done.

https://codereview.chromium.org/16425002/diff/1/Source/core/html/HTMLStyleEle...
File Source/core/html/HTMLStyleElement.cpp (right):

https://codereview.chromium.org/16425002/diff/1/Source/core/html/HTMLStyleEle...
Source/core/html/HTMLStyleElement.cpp:208:
StyleElement::insertedIntoDocument(document(), this);
On 2013/06/05 07:21:06, morrita1 wrote:
> This should no longer be insertedIntoDocument().

Done.

[Hajime Morrita, 2013-06-05 09:34:19]

OK, lgtm.

[commit-bot: I haz the power, 2013-06-05 09:50:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/16425002/7001

[tasak, 2013-06-05 09:50:35]

On 2013/06/05 09:34:19, morrita1 wrote:
> OK, lgtm.

Thank you. I will try to commit by CQ.

[commit-bot: I haz the power, 2013-06-05 10:54:41]

Change committed as 151825