Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/public/platform/WebMemoryDumpProvider.h

Issue 1642023007: Refactoring: Move functions from WebMemoryDumpProviderAdapter to PartitionAllocMemoryDumpProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: primiano's review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/DEPS ('k') | third_party/WebKit/public/platform/WebProcessMemoryDump.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMemoryDumpProvider.h
diff --git a/third_party/WebKit/public/platform/WebMemoryDumpProvider.h b/third_party/WebKit/public/platform/WebMemoryDumpProvider.h
index 2cc644db8f7742c67873195ac5defd6151a7c57e..725c92ad5794bcdf757ec71ed4b8455f30c85ccb 100644
--- a/third_party/WebKit/public/platform/WebMemoryDumpProvider.h
+++ b/third_party/WebKit/public/platform/WebMemoryDumpProvider.h
@@ -13,6 +13,8 @@ class WebProcessMemoryDump;
// Used to specify the type of memory dump the WebMemoryDumpProvider should
// generate on dump requests.
+// TODO(hajimehoshi): Remove this and use base::trace_event::
+// MemoryDumpLevelOfDetail instead.
enum class WebMemoryDumpLevelOfDetail {
Light,
Detailed
@@ -45,10 +47,9 @@ public:
// provider itself.
virtual bool supportsHeapProfiling() { return false; }
- // Called by the memory dump manager to enable heap profiling (with
- // non-null hook functions) or called to disable heap profiling (with null
- // pointers).
- virtual void onHeapProfilingEnabled(AllocationHook* allocationHook, FreeHook* freeHook) {}
+ // Called by the memory dump manager to enable heap profiling (with true) or
+ // called to disable heap profiling (with false).
+ virtual void onHeapProfilingEnabled(bool enabled) {}
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/platform/DEPS ('k') | third_party/WebKit/public/platform/WebProcessMemoryDump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698