Issue 16415002: Remove some unused variable assignments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16415002: Remove some unused variable assignments (Closed)

Created:
7 years, 6 months ago by Timothy Loh

Modified:
7 years, 6 months ago

Reviewers:
Nico

CC:
blink-reviews, jeez, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

Remove some unused variable assignments These were found by static code analysis tool cppcheck BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151807

Patch Set 2 : reduce scope of endOffset #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
M	Source/core/editing/ApplyStyleCommand.cpp	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/platform/ScrollView.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderListItem.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm with the comment below addressed https://codereview.chromium.org/16415002/diff/1/Source/core/editing/ApplyStyleCommand.cpp File Source/core/editing/ApplyStyleCommand.cpp (left): https://codereview.chromium.org/16415002/diff/1/Source/core/editing/ApplyStyleCommand.cpp#oldcode1295 Source/core/editing/ApplyStyleCommand.cpp:1295: int endOffset = ...

7 years, 6 months ago (2013-06-05 04:09:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16415002/3001

7 years, 6 months ago (2013-06-05 04:46:16 UTC) #2

Message was sent while issue was closed.

Change committed as 151807

Expand Messages | Collapse Messages

Issue 16415002: Remove some unused variable assignments (Closed)

Description

Patch Set 1 #

Patch Set 2 : reduce scope of endOffset #

Messages