Issue 16413007: Make FileSystemOperation NOT self-destruct

Issue 16413007: Make FileSystemOperation NOT self-destruct (Closed)

Created:
7 years, 6 months ago by kinuko

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, vandebo (ex-Chrome), kinaba, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, satorux1, Lei Zhang

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make FileSystemOperation NOT self-destruct This architecture was found to bring lots of undesirable complexity in the codebase. This should become much simpler. BUG=176444 TEST=unit_tests:*File*, content_unittests:*File*, browser_tests:*File* NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205243

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixing memory issues #

Patch Set 3 : fix browser_tests #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+416 lines, -602 lines)			Patch
M	chrome/browser/media_galleries/fileapi/device_media_async_file_util.h	View		3 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc	View		15 chunks	+35 lines, -34 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/native_media_file_util.h	View		1 chunk	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/native_media_file_util.cc	View	1	7 chunks	+46 lines, -34 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	content/browser/fileapi/fileapi_message_filter.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/browser/chromeos/fileapi/remote_file_system_operation.h	View		4 chunks	+6 lines, -18 lines	0 comments	Download
M	webkit/browser/chromeos/fileapi/remote_file_system_operation.cc	View		15 chunks	+28 lines, -92 lines	0 comments	Download
M	webkit/browser/fileapi/async_file_util.h	View	1	15 chunks	+19 lines, -13 lines	0 comments	Download
M	webkit/browser/fileapi/async_file_util_adapter.h	View	1	2 chunks	+18 lines, -16 lines	0 comments	Download
M	webkit/browser/fileapi/async_file_util_adapter.cc	View		1 chunk	+55 lines, -40 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_context.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/browser/fileapi/file_writer_delegate.h	View		4 chunks	+6 lines, -11 lines	0 comments	Download
M	webkit/browser/fileapi/file_writer_delegate.cc	View		6 chunks	+14 lines, -15 lines	0 comments	Download
M	webkit/browser/fileapi/local_file_system_operation.h	View		7 chunks	+7 lines, -41 lines	0 comments	Download
M	webkit/browser/fileapi/local_file_system_operation.cc	View		31 chunks	+79 lines, -150 lines	0 comments	Download
M	webkit/browser/fileapi/syncable/syncable_file_system_operation.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/browser/fileapi/syncable/syncable_file_system_operation.cc	View		19 chunks	+49 lines, -96 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinuko

Please take a look, vandebo|thestig: chrome/browser/media_galleries/* kinaba: webkit/browser/chromeos/fileapi/* tzik: webkit/browser/fileapi* and in general Thanks!

7 years, 6 months ago (2013-06-10 05:12:40 UTC) #1

Lei Zhang

c/b/media_galleries lgtm https://codereview.chromium.org/16413007/diff/1/chrome/browser/media_galleries/fileapi/native_media_file_util.cc File chrome/browser/media_galleries/fileapi/native_media_file_util.cc (right): https://codereview.chromium.org/16413007/diff/1/chrome/browser/media_galleries/fileapi/native_media_file_util.cc#newcode497 chrome/browser/media_galleries/fileapi/native_media_file_util.cc:497: context, url, &file_path); nit: this was fine ...

7 years, 6 months ago (2013-06-10 05:34:54 UTC) #2

kinuko

https://codereview.chromium.org/16413007/diff/1/chrome/browser/media_galleries/fileapi/native_media_file_util.cc File chrome/browser/media_galleries/fileapi/native_media_file_util.cc (right): https://codereview.chromium.org/16413007/diff/1/chrome/browser/media_galleries/fileapi/native_media_file_util.cc#newcode497 chrome/browser/media_galleries/fileapi/native_media_file_util.cc:497: context, url, &file_path); On 2013/06/10 05:34:54, Lei Zhang wrote: ...

7 years, 6 months ago (2013-06-10 06:46:31 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/16413007/41001

7 years, 6 months ago (2013-06-10 17:51:51 UTC) #6

Message was sent while issue was closed.

Change committed as 205243

Expand Messages | Collapse Messages