Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 16413005: Stop running media layout tests as browser tests (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -100 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 1 chunk +0 lines, -8 lines 0 comments Download
D content/browser/media/audio_browsertest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
jochen (gone - plz use gerrit)
7 years, 6 months ago (2013-06-06 20:35:59 UTC) #1
scherkus (not reviewing)
Can you also remove the references from build/android/pylib/gtest/filter/content_browsertests_disabled ?
7 years, 6 months ago (2013-06-06 20:39:05 UTC) #2
jochen (gone - plz use gerrit)
done
7 years, 6 months ago (2013-06-06 20:45:29 UTC) #3
scherkus (not reviewing)
lgtm
7 years, 6 months ago (2013-06-06 20:48:39 UTC) #4
shadi
what is the reason for this? bug reference? On Thu, Jun 6, 2013 at 1:48 ...
7 years, 6 months ago (2013-06-06 20:52:32 UTC) #5
scherkus (not reviewing)
On 2013/06/06 20:52:32, shadi wrote: > what is the reason for this? bug reference? layout ...
7 years, 6 months ago (2013-06-06 20:55:50 UTC) #6
jochen (gone - plz use gerrit)
On 2013/06/06 20:55:50, scherkus wrote: > On 2013/06/06 20:52:32, shadi wrote: > > what is ...
7 years, 6 months ago (2013-06-06 20:56:12 UTC) #7
shadi
LGTM
7 years, 6 months ago (2013-06-06 21:08:26 UTC) #8
jam
lgtm
7 years, 6 months ago (2013-06-07 00:49:58 UTC) #9
jam
lgtm, please mark all the associated bugs in this file as WontFix.
7 years, 6 months ago (2013-06-07 00:51:40 UTC) #10
jochen (gone - plz use gerrit)
On 2013/06/07 00:51:40, jam wrote: > lgtm, please mark all the associated bugs in this ...
7 years, 6 months ago (2013-06-07 07:39:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16413005/6001
7 years, 6 months ago (2013-06-07 07:39:53 UTC) #12
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 13:39:43 UTC) #13
Message was sent while issue was closed.
Change committed as 204813

Powered by Google App Engine
This is Rietveld 408576698