Don't delete leveldb directory if disk was full.

Don't delete leveldb directory if disk was full.

Also, equally as important, don't count a full disk as a corruption.

This patch's functionality was added to IDB in blink, but after the IDB
team forked the blink code to port to chromium.
See http://src.chromium.org/viewvc/blink?view=rev&rev=150406 for the
original blink patch.

BUG=239882
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204963

[dgrogan, 2013-06-07 17:09:01]

Josh, could you review this? You reviewed the blink version ~month ago.

[jsbell, 2013-06-07 17:48:41]

Is the patch missing something, or am I?

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
File content/browser/indexed_db/indexed_db_backing_store.cc (right):

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
content/browser/indexed_db/indexed_db_backing_store.cc:502: bool is_disk_full =
false;
This isn't used. In the Blink patch we assert, log, histogram and fail the open
so that we don't fall into the failure code.

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
File content/browser/indexed_db/indexed_db_backing_store.h (right):

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
content/browser/indexed_db/indexed_db_backing_store.h:35: bool* is_disk_full =
0) = 0;
NULL is preferred over 0.

[dgrogan, 2013-06-07 18:23:58]

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
File content/browser/indexed_db/indexed_db_backing_store.cc (right):

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
content/browser/indexed_db/indexed_db_backing_store.cc:502: bool is_disk_full =
false;
On 2013/06/07 17:48:41, jsbell wrote:
> This isn't used. In the Blink patch we assert, log, histogram and fail the
open
> so that we don't fall into the failure code.

Thanks for catching this. I decided the blink behavior isn't exactly right. In
blink, even if the database was successfully opened we'd throw an error if the
disk was full. I'd rather it be such that if the database is successfully opened
and read we return success even if the disk is full. Who knows, some space may
have been freed between checking and opening.

The important part is not deleting data when the disk is full.

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
File content/browser/indexed_db/indexed_db_backing_store.h (right):

https://codereview.chromium.org/16409006/diff/18001/content/browser/indexed_d...
content/browser/indexed_db/indexed_db_backing_store.h:35: bool* is_disk_full =
0) = 0;
On 2013/06/07 17:48:41, jsbell wrote:
> NULL is preferred over 0.

Done.

[jsbell, 2013-06-07 18:32:19]

lgtm with one nit

https://codereview.chromium.org/16409006/diff/24001/content/browser/indexed_d...
File content/browser/indexed_db/indexed_db_backing_store.cc (right):

https://codereview.chromium.org/16409006/diff/24001/content/browser/indexed_d...
content/browser/indexed_db/indexed_db_backing_store.cc:541: if (is_disk_full) {
This can be written as an "else if" clause rather than a nested if

[commit-bot: I haz the power, 2013-06-07 18:39:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/16409006/28001

[dgrogan, 2013-06-07 18:39:44]

https://codereview.chromium.org/16409006/diff/24001/content/browser/indexed_d...
File content/browser/indexed_db/indexed_db_backing_store.cc (right):

https://codereview.chromium.org/16409006/diff/24001/content/browser/indexed_d...
content/browser/indexed_db/indexed_db_backing_store.cc:541: if (is_disk_full) {
On 2013/06/07 18:32:19, jsbell wrote:
> This can be written as an "else if" clause rather than a nested if

Moved.

[commit-bot: I haz the power, 2013-06-07 22:32:50]

Change committed as 204963