Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16402012: Use a direct include of strings headers in ui/, part 1. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, James Su, sadrul, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, penghuang+watch_chromium.org, sail+watch_chromium.org, davidbarr+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dcheng, ctguil+watch_chromium.org, jshin+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in ui/, part 1. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -70 lines) Patch
M ui/app_list/app_list_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/test/apps_grid_controller_test_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/pagination_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_box_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_result.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/signin_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/test/app_list_test_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_main_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/cursor_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_root_window_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_windows.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/accelerators/accelerator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accessibility/accessible_text_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accessibility/accessible_text_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accessibility/accessible_view_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_util_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/find_pasteboard.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/menu_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursor_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursor_loader_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/cocoa_dnd_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/gtk_dnd_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gtk/gtk_im_context_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gtk/menu_label_accelerator_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/character_composer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/composition_text.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/fake_input_method.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_ibus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/text_input_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/win/tsf_text_store.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/keycodes/keyboard_code_conversion_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_font_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/l10n/l10n_util_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16402012/1
7 years, 6 months ago (2013-06-10 23:11:28 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 12:31:10 UTC) #2
Message was sent while issue was closed. 
Change committed as 205507

Powered by Google App Engine
This is Rietveld 408576698