Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16391006: Use a direct include of strings headers in chrome_frame/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things), grt+watch_chromium.org, amit, robertshield, asvitkine+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Use a direct include of strings headers in chrome_frame/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -85 lines) Patch
M chrome_frame/bho.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/bind_status_callback_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_launcher_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_tab.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/com_message_event.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/crash_reporting/nt_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/dll_redirector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/find_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/html_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/http_negotiate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/navigation_constraints.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/policy_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/protocol_sink_wrap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/ready_mode/internal/registry_ready_mode_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/registry_list_preferences_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/registry_list_preferences_holder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/simple_resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/automation_client_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/dll_redirector_loading_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/http_negotiate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/ie_configurator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/test/infobar_unittests.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/policy_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/test_scrubber.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_server.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_with_web_server.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/util_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/win_event_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/urlmon_bind_status_callback.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_moniker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16391006/1
7 years, 6 months ago (2013-06-10 20:07:20 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160751
7 years, 6 months ago (2013-06-11 01:25:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16391006/1
7 years, 6 months ago (2013-06-11 03:40:29 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 04:42:13 UTC) #4
Message was sent while issue was closed. 
Change committed as 205413

Powered by Google App Engine
This is Rietveld 408576698