Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 16387006: Simplifying error recovery in declaration list. (Closed)

Created:
7 years, 6 months ago by SeRya
Modified:
7 years, 6 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org, Dmitry Zvorygin
Visibility:
Public.

Description

Simplifying error recovery in declaration list. Now declaration handles all errors (instead of splitting error hendling among declaration, delaration_list and decl_list). Changed error message when syntax error appear in a property value (now it is reported as invalid property value with whole value quited). Previously it was used only for symantic errors. CSS error filtering moved into frontend in order to make possible to test the change. The place where filtering happen is not the place where other messages are filtered. It needed in order to not affect warning counter (should filtering be moved entirely into ConsoleModel? I think situation when error counter shows 15 messages but console shoow 3 is confusing). BUG=140608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152130

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -37 lines) Patch
M Source/core/css/CSSGrammar.y.in View 1 2 5 chunks +12 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
SeRya
This includes enables CSS warnings but this part is not supposed to commit (just for ...
7 years, 6 months ago (2013-06-06 15:41:09 UTC) #1
SeRya
7 years, 6 months ago (2013-06-09 13:16:01 UTC) #2
SeRya
Reverted testing infrastructure changes.
7 years, 6 months ago (2013-06-10 09:13:58 UTC) #3
apavlov
lgtm
7 years, 6 months ago (2013-06-10 11:13:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/16387006/22001
7 years, 6 months ago (2013-06-10 11:13:44 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 12:55:46 UTC) #6
Message was sent while issue was closed.
Change committed as 152130

Powered by Google App Engine
This is Rietveld 408576698