Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: Source/core/dom/CharacterData.h

Issue 16379002: inline WebCore::Node::Node constructor more safely (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: style fixes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.h » ('j') | Source/core/dom/Text.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 StringImpl* dataImpl() { return m_data.impl(); } 44 StringImpl* dataImpl() { return m_data.impl(); }
45 45
46 // Like appendData, but optimized for the parser (e.g., no mutation events). 46 // Like appendData, but optimized for the parser (e.g., no mutation events).
47 // Returns how much could be added before length limit was met. 47 // Returns how much could be added before length limit was met.
48 unsigned parserAppendData(const String& string, unsigned offset, unsigned le ngthLimit); 48 unsigned parserAppendData(const String& string, unsigned offset, unsigned le ngthLimit);
49 49
50 virtual void reportMemoryUsage(MemoryObjectInfo*) const; 50 virtual void reportMemoryUsage(MemoryObjectInfo*) const;
51 51
52 protected: 52 protected:
53 CharacterData(Document* document, const String& text, ConstructionType type) 53 CharacterData(TreeScope* treeScope, const String& text, ConstructionType typ e)
54 : Node(document, type) 54 : Node(treeScope, type)
55 , m_data(!text.isNull() ? text : emptyString()) 55 , m_data(!text.isNull() ? text : emptyString())
56 { 56 {
57 ASSERT(type == CreateOther || type == CreateText || type == CreateEditin gText); 57 ASSERT(type == CreateOther || type == CreateText || type == CreateEditin gText);
58 ScriptWrappable::init(this); 58 ScriptWrappable::init(this);
59 } 59 }
60 60
61 void setDataWithoutUpdate(const String& data) 61 void setDataWithoutUpdate(const String& data)
62 { 62 {
63 ASSERT(!data.isNull()); 63 ASSERT(!data.isNull());
64 m_data = data; 64 m_data = data;
65 } 65 }
66 void dispatchModifiedEvent(const String& oldValue); 66 void dispatchModifiedEvent(const String& oldValue);
67 67
68 private: 68 private:
69 virtual String nodeValue() const OVERRIDE FINAL; 69 virtual String nodeValue() const OVERRIDE FINAL;
70 virtual void setNodeValue(const String&, ExceptionCode&) OVERRIDE FINAL; 70 virtual void setNodeValue(const String&, ExceptionCode&) OVERRIDE FINAL;
71 virtual bool isCharacterDataNode() const OVERRIDE FINAL { return true; } 71 virtual bool isCharacterDataNode() const OVERRIDE FINAL { return true; }
72 virtual int maxCharacterOffset() const OVERRIDE FINAL; 72 virtual int maxCharacterOffset() const OVERRIDE FINAL;
73 virtual bool offsetInCharacters() const OVERRIDE FINAL; 73 virtual bool offsetInCharacters() const OVERRIDE FINAL;
74 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength); 74 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength);
75 void checkCharDataOperation(unsigned offset, ExceptionCode&); 75 void checkCharDataOperation(unsigned offset, ExceptionCode&);
76 76
77 String m_data; 77 String m_data;
78 }; 78 };
79 79
80 } // namespace WebCore 80 } // namespace WebCore
81 81
82 #endif // CharacterData_h 82 #endif // CharacterData_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.h » ('j') | Source/core/dom/Text.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698