chrome/browser/ui/views/simple_message_box_views.cc - Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert changes to c/b/chromeos files for now. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/simple_message_box_views.cc

diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc

index d7c8c2556a216a1b686c1b5dfd20419c39c41828..a4a7029af5f6d446e8353e1b657984dfe520cc1f 100644

--- a/chrome/browser/ui/views/simple_message_box_views.cc

+++ b/chrome/browser/ui/views/simple_message_box_views.cc

@@ -10,6 +10,7 @@

#include "base/message_loop.h"

#include "base/run_loop.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/ui/views/constrained_window_views.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/gfx/native_widget_types.h"

@@ -175,7 +176,7 @@ MessageBoxResult ShowMessageBox(gfx::NativeWindow parent,

MessageBoxType type) {

scoped_refptr<SimpleMessageBoxViews> dialog(

new SimpleMessageBoxViews(title, message, type));

- views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent)->Show();

+ CreateBrowserModalDialogViews(dialog, parent)->Show();

#if defined(USE_AURA)

// Use the widget's window itself so that the message loop