chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert changes to c/b/chromeos files for now. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_dialog.cc ('k') | chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index 4023f7ca295a7ca5045f1f4758f786ba61a59cd5..1a6aef83cd0b314d4879b297bb6ce5e8e8988bd3 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/extensions/bundle_installer.h"

#include "chrome/browser/extensions/extension_install_prompt.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/views/constrained_window_views.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/installer/util/browser_distribution.h"

@@ -185,9 +186,9 @@ void ShowExtensionInstallDialogImpl(

ExtensionInstallPrompt::Delegate* delegate,

const ExtensionInstallPrompt::Prompt& prompt) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

- views::DialogDelegate::CreateDialogWidget(

+ CreateBrowserModalDialogViews(

new ExtensionInstallDialogView(show_params.navigator, delegate, prompt),

- NULL, show_params.parent_window)->Show();

+ show_params.parent_window)->Show();

}

} // namespace