chrome/browser/ui/views/download/download_in_progress_dialog_view.cc - Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_in_progress_dialog_view.cc

Issue 16374006: Place browser-modal dialogs like web-contents-modal dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert changes to c/b/chromeos files for now. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/create_application_shortcut_view.cc ('k') | chrome/browser/ui/views/edit_search_engine_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_in_progress_dialog_view.cc

diff --git a/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc b/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc

index fca2c5aad78e94ccc6a3660692a615c82bc06499..15bc3c1315d9d5d9ec0fc8af22f7503b0a6be69c 100644

--- a/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc

+++ b/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc

@@ -8,6 +8,7 @@

#include "base/strings/string_number_conversions.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/views/constrained_window_views.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#include "grit/locale_settings.h"

@@ -24,7 +25,7 @@ void DownloadInProgressDialogView::Show(Browser* browser,

gfx::NativeWindow parent) {

DownloadInProgressDialogView* window =

new DownloadInProgressDialogView(browser);

- views::DialogDelegate::CreateDialogWidget(window, NULL, parent)->Show();

+ CreateBrowserModalDialogViews(window, parent)->Show();

}

DownloadInProgressDialogView::DownloadInProgressDialogView(Browser* browser)